[llvm] RuntimeLibcalls: Pass in FloatABI and EABI type (PR #144691)

Peter Smith via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 18 08:38:53 PDT 2025


================
@@ -65,7 +65,17 @@ static void setAArch64LibcallNames(RuntimeLibcallsInfo &Info,
 #undef LCALLNAME5
 }
 
-static void setARMLibcallNames(RuntimeLibcallsInfo &Info, const Triple &TT) {
+static void setARMLibcallNames(RuntimeLibcallsInfo &Info, const Triple &TT,
+                               FloatABI::ABIType FloatABIType,
+                               EABI EABIVersion) {
----------------
smithp35 wrote:

The EABIVersion doesn't seem to be used by this function, or at least not yet.

Looks like it is only used in https://github.com/llvm/llvm-project/blob/main/llvm/lib/Target/ARM/ARMISelLowering.cpp#L693

Is the intention to move that part of the code to here at some point?

My apologies if I've missed some context, just seeing these reviews for the first time.

https://github.com/llvm/llvm-project/pull/144691


More information about the llvm-commits mailing list