[llvm] c16dc63 - [OMPIRBuilder] Fix gcc -Wparentheses warning [NFC]
Mikael Holmen via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 18 02:01:44 PDT 2025
Author: Mikael Holmen
Date: 2025-06-18T10:59:18+02:00
New Revision: c16dc63b44ae039f2ac123a8ffbc90031767d00b
URL: https://github.com/llvm/llvm-project/commit/c16dc63b44ae039f2ac123a8ffbc90031767d00b
DIFF: https://github.com/llvm/llvm-project/commit/c16dc63b44ae039f2ac123a8ffbc90031767d00b.diff
LOG: [OMPIRBuilder] Fix gcc -Wparentheses warning [NFC]
Without this gcc warned like
/repo/llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:7559:68: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
7559 | NumStaleCIArgs == (OffloadingArraysToPrivatize.size() + 2) &&
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
7560 | "Wrong number of arguments for StaleCI when shareds are present");
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Added:
Modified:
llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp
Removed:
################################################################################
diff --git a/llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp b/llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp
index 7cbbbff511c88..ddc9c5392f922 100644
--- a/llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp
+++ b/llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp
@@ -7558,10 +7558,9 @@ OpenMPIRBuilder::InsertPointOrErrorTy OpenMPIRBuilder::emitTargetTask(
// StaleCI is exactly OffloadingArraysToPrivatize.size() + 2
const unsigned int NumStaleCIArgs = StaleCI->arg_size();
bool HasShareds = NumStaleCIArgs > OffloadingArraysToPrivatize.size() + 1;
- assert(
- !HasShareds ||
- NumStaleCIArgs == (OffloadingArraysToPrivatize.size() + 2) &&
- "Wrong number of arguments for StaleCI when shareds are present");
+ assert((!HasShareds ||
+ NumStaleCIArgs == (OffloadingArraysToPrivatize.size() + 2)) &&
+ "Wrong number of arguments for StaleCI when shareds are present");
int SharedArgOperandNo =
HasShareds ? OffloadingArraysToPrivatize.size() + 1 : 0;
More information about the llvm-commits
mailing list