[llvm] [ORC] Fix synchronization in CoreAPIsTest. (PR #144556)

Lang Hames via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 17 17:11:45 PDT 2025


================
@@ -1559,16 +1559,13 @@ TEST_F(CoreAPIsStandardTest, TestLookupWithThreadedMaterialization) {
 #if LLVM_ENABLE_THREADS
 
   std::mutex WorkThreadsMutex;
-  std::vector<std::thread> WorkThreads;
+  SmallVector<std::thread,0> WorkThreads;
   DispatchOverride = [&](std::unique_ptr<Task> T) {
-    std::promise<void> WaitP;
-    std::lock_guard<std::mutex> Lock(WorkThreadsMutex);
+    std::unique_lock Lock(WorkThreadsMutex);
----------------
lhames wrote:

I think this could remain a `lock_guard`, since manual locking/unlocking isn't needed here.

https://github.com/llvm/llvm-project/pull/144556


More information about the llvm-commits mailing list