[llvm] [llvm-debuginfo-analyzer] Fix crash with WebAssembly dead code (PR #141616)

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 17 11:07:56 PDT 2025


================
@@ -193,11 +193,17 @@ class LVCodeViewReader final : public LVBinaryReader {
                    llvm::object::COFFObjectFile &Obj, ScopedPrinter &W,
                    StringRef ExePath)
       : LVBinaryReader(Filename, FileFormatName, W, LVBinaryType::COFF),
-        Input(&Obj), ExePath(ExePath), LogicalVisitor(this, W, Input) {}
+        Input(&Obj), ExePath(ExePath), LogicalVisitor(this, W, Input) {
+    // CodeView does not have the concept of 'tombstone' address.
----------------
dwblaikie wrote:

Comment could be a bit more descriptive about why we then set the tombstone to maxaddress - even though CV doesn't have a tombstone?

But my suspicion/theory is that perhaps we can leave this unset? Or further - why is the tombstone a member of the LVReader - could it be only a member of the LVDWARFReader? It's the only one that sets or gets the value?

https://github.com/llvm/llvm-project/pull/141616


More information about the llvm-commits mailing list