[lld] [llvm] [lld][COFF] Remove duplicate strtab entries (PR #141197)

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 16 23:44:47 PDT 2025


================
@@ -121,7 +121,7 @@ void COFFWriter::layoutSections() {
 Expected<size_t> COFFWriter::finalizeStringTable() {
   for (const auto &S : Obj.getSections())
     if (S.Name.size() > COFF::NameSize)
-      StrTabBuilder.add(S.Name);
+      StrTabBuilder.add(S.Name, /*Priority=*/UINT8_MAX);
----------------
jh7370 wrote:

This feels like an unrelated change. Is it even necessary? If it is important, should it have a test and should it be in its own PR?

https://github.com/llvm/llvm-project/pull/141197


More information about the llvm-commits mailing list