[llvm] [VPlan] Use VPInstructionWithType for uniform casts. (PR #140623)

Luke Lau via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 11 03:04:01 PDT 2025


================
@@ -1067,8 +1070,9 @@ class VPInstructionWithType : public VPInstruction {
 public:
   VPInstructionWithType(unsigned Opcode, ArrayRef<VPValue *> Operands,
                         Type *ResultTy, const VPIRFlags &Flags, DebugLoc DL,
-                        const Twine &Name = "")
-      : VPInstruction(Opcode, Operands, Flags, DL, Name), ResultTy(ResultTy) {}
+                        bool SingleScalar = false, const Twine &Name = "")
----------------
lukel97 wrote:

Nit, should this match the VPInstruction arg name?
```suggestion
                        bool IsSingleScalar = false, const Twine &Name = "")
```

https://github.com/llvm/llvm-project/pull/140623


More information about the llvm-commits mailing list