[compiler-rt] [compiler-rt] replicate changes from llvm/ProfileData/InstrProfData.inc (PR #143574)
Aiden Grossman via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 10 13:27:37 PDT 2025
boomanaiden154 wrote:
> It doesn't; it is relying on picking it up from llvm/include/Support/Compiler.h
And that's getting pulled into the `compiler-rt` build tree? I'm mostly just wondering why we aren't running into build errors when compiling compiler-rt.
> this is basically just to appease the diff check; the dll annotations aren't being applied to the profile runtime. I don't think that the profile runtime should be exposing these interfaces ever (the runtime's ABI is a pure C interface).
Yeah, I got that this was to appease the diff check. I agree it doesn't make sense to export them from the runtime given it's always (?) statically linked and a pure C interface. Having `LLVM_ABI` be noop on the compiler-rt side for the common headers seems reasonable enough to me (or some other annotation in the file that maps to LLVM_ABI in certain contexts that is more clear). I guess stripping `LLVM_ABI` and then running `diff` would work too.
https://github.com/llvm/llvm-project/pull/143574
More information about the llvm-commits
mailing list