[llvm] [llvm] remove llvm:: qualification from appendLoopsToWorklist extern template instantiations (PR #143555)

Andrew Rogers via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 10 08:35:02 PDT 2025


https://github.com/andrurogerz created https://github.com/llvm/llvm-project/pull/143555

## Purpose
Fix a build break introduced by #143413. This was a copy+paste error where the `llvm::` qualifier was left on the template instantiation declarations that were added. This causes a compile error with the version of the compiler used by the mlir-nvidia-gcc7 build. 
```
/vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.src/llvm/include/llvm/Transforms/Utils/LoopUtils.h:539:72: error: explicit qualification in declaration of ‘void llvm::appendLoopsToWorklist(llvm::ArrayRef<llvm::Loop*>&, llvm::SmallPriorityWorklist<llvm::Loop*, 4>&)’
     ArrayRef<Loop *> &Loops, SmallPriorityWorklist<Loop *, 4> &Worklist);
                                                                        ^
/vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.src/llvm/include/llvm/Transforms/Utils/LoopUtils.h:543:79: error: explicit qualification in declaration of ‘void llvm::appendLoopsToWorklist(llvm::Loop&, llvm::SmallPriorityWorklist<llvm::Loop*, 4>&)’
                                     SmallPriorityWorklist<Loop *, 4> &Worklist);
```

>From 00b655e6b2fc1cb5c71421952a479c0d0773bb3a Mon Sep 17 00:00:00 2001
From: Andrew Rogers <andrurogerz at gmail.com>
Date: Tue, 10 Jun 2025 08:29:28 -0700
Subject: [PATCH] remove llvm:: qualification from appendLoopsToWorklist
 template instantiation decls

---
 llvm/include/llvm/Transforms/Utils/LoopUtils.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/llvm/include/llvm/Transforms/Utils/LoopUtils.h b/llvm/include/llvm/Transforms/Utils/LoopUtils.h
index e4bfd7659313b..6c0e06482a6de 100644
--- a/llvm/include/llvm/Transforms/Utils/LoopUtils.h
+++ b/llvm/include/llvm/Transforms/Utils/LoopUtils.h
@@ -535,12 +535,12 @@ void appendReversedLoopsToWorklist(RangeT &&,
                                    SmallPriorityWorklist<Loop *, 4> &);
 
 extern template LLVM_TEMPLATE_ABI void
-llvm::appendLoopsToWorklist<ArrayRef<Loop *> &>(
+appendLoopsToWorklist<ArrayRef<Loop *> &>(
     ArrayRef<Loop *> &Loops, SmallPriorityWorklist<Loop *, 4> &Worklist);
 
 extern template LLVM_TEMPLATE_ABI void
-llvm::appendLoopsToWorklist<Loop &>(Loop &L,
-                                    SmallPriorityWorklist<Loop *, 4> &Worklist);
+appendLoopsToWorklist<Loop &>(Loop &L,
+                              SmallPriorityWorklist<Loop *, 4> &Worklist);
 
 /// Utility that implements appending of loops onto a worklist given LoopInfo.
 /// Calls the templated utility taking a Range of loops, handing it the Loops



More information about the llvm-commits mailing list