[lld] 4cafd28 - [lld] Delete lto-late-arm.ll
Aiden Grossman via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 10 00:35:49 PDT 2025
Author: Aiden Grossman
Date: 2025-06-10T07:35:41Z
New Revision: 4cafd28b7dd92080103d11cccc78d9a2f01e1242
URL: https://github.com/llvm/llvm-project/commit/4cafd28b7dd92080103d11cccc78d9a2f01e1242
DIFF: https://github.com/llvm/llvm-project/commit/4cafd28b7dd92080103d11cccc78d9a2f01e1242.diff
LOG: [lld] Delete lto-late-arm.ll
This test is failing on a couple of bots and on premerge after
a082f665f85b1002ab22af263eeafceca5288657.
That patch configures the relevant libcalls for ARM in RuntimeLibCalls.
This causes __rt_sdiv to get pulled into the LTO preopt IR. This should
happen for other builtins as well, which means that the original issue
that the patch introducing this patch intended to diagnose should no
longer exist.
The compiler generated calls to builtins mentioned in
7f9a0048fa3fb5513c09731a7f82a851b0bcd609 should always have definitions,
assuming they are available in the link and will not only get pulled in
late if lazily loading symbols from archives. We otherwise get the
standard diagnostic if they are not.
Added:
Modified:
Removed:
lld/test/COFF/lto-late-arm.ll
################################################################################
diff --git a/lld/test/COFF/lto-late-arm.ll b/lld/test/COFF/lto-late-arm.ll
deleted file mode 100644
index 0e2f148ef74c6..0000000000000
--- a/lld/test/COFF/lto-late-arm.ll
+++ /dev/null
@@ -1,39 +0,0 @@
-; REQUIRES: arm
-
-;; A bitcode file can generate undefined references to symbols that weren't
-;; listed as undefined on the bitcode file itself, when lowering produces
-;; calls to e.g. builtin helper functions. If these functions are provided
-;; as LTO bitcode, the linker would hit an unhandled state. (In practice,
-;; compiler-rt builtins are always compiled with -fno-lto, so this shouldn't
-;; happen.)
-
-; RUN: rm -rf %t.dir
-; RUN: split-file %s %t.dir
-; RUN: llvm-as %t.dir/main.ll -o %t.main.obj
-; RUN: llvm-as %t.dir/sdiv.ll -o %t.sdiv.obj
-; RUN: llvm-ar rcs %t.sdiv.lib %t.sdiv.obj
-
-; RUN: env LLD_IN_TEST=1 not lld-link /entry:entry %t.main.obj %t.sdiv.lib /out:%t.exe /subsystem:console 2>&1 | FileCheck %s
-
-; CHECK: error: LTO object file lto-late-arm.ll.tmp.sdiv.lib(lto-late-arm.ll.tmp.sdiv.obj) linked in after doing LTO compilation.
-
-;--- main.ll
-target datalayout = "e-m:w-p:32:32-Fi8-i64:64-v128:64:128-a:0:32-n32-S64"
-target triple = "thumbv7-w64-windows-gnu"
-
- at num = dso_local global i32 100
-
-define dso_local arm_aapcs_vfpcc i32 @entry(i32 %param) {
-entry:
- %0 = load i32, ptr @num
- %div = sdiv i32 %0, %param
- ret i32 %div
-}
-;--- sdiv.ll
-target datalayout = "e-m:w-p:32:32-Fi8-i64:64-v128:64:128-a:0:32-n32-S64"
-target triple = "thumbv7-w64-windows-gnu"
-
-define dso_local arm_aapcs_vfpcc void @__rt_sdiv() {
-entry:
- ret void
-}
More information about the llvm-commits
mailing list