[llvm] [AMDGPUI][True16][CodeGen] global atomic load i8 in true16 mode (PR #142822)

Joe Nash via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 5 08:08:22 PDT 2025


================
@@ -1678,15 +1678,12 @@ def : FlatLoadPat_D16 <FLAT_LOAD_SHORT_D16, load_d16_lo_flat, v2f16>;
 let OtherPredicates = [HasFlatGlobalInsts] in {
 
 defm : GlobalFLATLoadPats <GLOBAL_LOAD_UBYTE, atomic_load_aext_8_global, i32>;
-defm : GlobalFLATLoadPats <GLOBAL_LOAD_UBYTE, atomic_load_aext_8_global, i16>;
 defm : GlobalFLATLoadPats <GLOBAL_LOAD_UBYTE, atomic_load_zext_8_global, i32>;
-defm : GlobalFLATLoadPats <GLOBAL_LOAD_UBYTE, atomic_load_zext_8_global, i16>;
 defm : GlobalFLATLoadPats <GLOBAL_LOAD_USHORT, atomic_load_aext_16_global, i32>;
 defm : GlobalFLATLoadPats <GLOBAL_LOAD_USHORT, atomic_load_nonext_16_global, i16>;
----------------
Sisyph wrote:

Yes, I would recommend to merge this patch now. But I suggest adding those other atomic patterns as an immediate follow up, because it seems to only be a matter of time until they will be hit in other test cases.

https://github.com/llvm/llvm-project/pull/142822


More information about the llvm-commits mailing list