[compiler-rt] [Sanitizer] XFAIL android test because env var is not read (PR #142234)

Ellis Hoag via llvm-commits llvm-commits at lists.llvm.org
Fri May 30 16:09:32 PDT 2025


https://github.com/ellishg updated https://github.com/llvm/llvm-project/pull/142234

>From a295b2a95b2ffb38da2d884263ebf1af016a05ef Mon Sep 17 00:00:00 2001
From: Ellis Hoag <ellis.sparky.hoag at gmail.com>
Date: Fri, 30 May 2025 16:02:32 -0700
Subject: [PATCH 1/2] [Sanitizer] XFAIL android test because env var is not
 read

---
 .../TestCases/Posix/sanitizer_set_report_path_fail.cpp        | 4 ++--
 .../TestCases/Posix/sanitizer_set_report_path_test.cpp        | 3 +++
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/compiler-rt/test/sanitizer_common/TestCases/Posix/sanitizer_set_report_path_fail.cpp b/compiler-rt/test/sanitizer_common/TestCases/Posix/sanitizer_set_report_path_fail.cpp
index 782cd0218fd22..af5187a0d3265 100644
--- a/compiler-rt/test/sanitizer_common/TestCases/Posix/sanitizer_set_report_path_fail.cpp
+++ b/compiler-rt/test/sanitizer_common/TestCases/Posix/sanitizer_set_report_path_fail.cpp
@@ -1,10 +1,10 @@
 // RUN: %clangxx -O2 %s -o %t
 
 // Case 1: Try setting a path that is an invalid/inaccessible directory.
-// RUN: not %env %run %t 2>&1 | FileCheck %s --check-prefix=ERROR1
+// RUN: not %run %t 2>&1 | FileCheck %s --check-prefix=ERROR1
 
 // Case 2: Try setting a path that is too large.
-// RUN: not %env %run %t A 2>&1 | FileCheck %s --check-prefix=ERROR2
+// RUN: not %run %t A 2>&1 | FileCheck %s --check-prefix=ERROR2
 
 #include <sanitizer/common_interface_defs.h>
 #include <stdio.h>
diff --git a/compiler-rt/test/sanitizer_common/TestCases/Posix/sanitizer_set_report_path_test.cpp b/compiler-rt/test/sanitizer_common/TestCases/Posix/sanitizer_set_report_path_test.cpp
index 8abd476708b4c..d83081ea607b6 100644
--- a/compiler-rt/test/sanitizer_common/TestCases/Posix/sanitizer_set_report_path_test.cpp
+++ b/compiler-rt/test/sanitizer_common/TestCases/Posix/sanitizer_set_report_path_test.cpp
@@ -2,6 +2,9 @@
 // RUN: %clangxx -O2 %s -o %t
 // RUN: %env HOME=%t.homedir TMPDIR=%t.tmpdir %run %t 2>&1 | FileCheck %s
 
+// FIXME: Environment variables are no propagated or not properly read on android.
+// XFAIL: android
+
 #include <sanitizer/common_interface_defs.h>
 #include <stdio.h>
 #include <string.h>

>From e68e71e2ffc941ae3382d77f8f2e2bfbd4f9e4e7 Mon Sep 17 00:00:00 2001
From: Ellis Hoag <ellis.sparky.hoag at gmail.com>
Date: Fri, 30 May 2025 16:09:22 -0700
Subject: [PATCH 2/2] add a t

---
 .../TestCases/Posix/sanitizer_set_report_path_test.cpp          | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/compiler-rt/test/sanitizer_common/TestCases/Posix/sanitizer_set_report_path_test.cpp b/compiler-rt/test/sanitizer_common/TestCases/Posix/sanitizer_set_report_path_test.cpp
index d83081ea607b6..12a1683c189bc 100644
--- a/compiler-rt/test/sanitizer_common/TestCases/Posix/sanitizer_set_report_path_test.cpp
+++ b/compiler-rt/test/sanitizer_common/TestCases/Posix/sanitizer_set_report_path_test.cpp
@@ -2,7 +2,7 @@
 // RUN: %clangxx -O2 %s -o %t
 // RUN: %env HOME=%t.homedir TMPDIR=%t.tmpdir %run %t 2>&1 | FileCheck %s
 
-// FIXME: Environment variables are no propagated or not properly read on android.
+// FIXME: Environment variables are not propagated or not properly read on android.
 // XFAIL: android
 
 #include <sanitizer/common_interface_defs.h>



More information about the llvm-commits mailing list