[llvm] [SandboxIR][Region] Auxiliary vector metadata now requires a region (PR #137443)
via llvm-commits
llvm-commits at lists.llvm.org
Tue May 27 10:07:07 PDT 2025
================
@@ -115,7 +115,7 @@ class Region {
Context::CallbackID EraseInstCB;
/// Adds I to the set.
- void add(Instruction *I);
+ void add(Instruction *I, bool TrackScore = true);
----------------
vporpo wrote:
I think it's better to keep two functions because it make is more obvious which one is the one you should avoid.
Regarding the boolean name, it is indeed confusing. How about `IgnoreScore` or `SkipScore`? I prefer the flipped logic compared to the original version because it kind of implies that tracking the score is the normal think to do.
https://github.com/llvm/llvm-project/pull/137443
More information about the llvm-commits
mailing list