[llvm] [SandboxIR][Region] Auxiliary vector metadata now requires a region (PR #137443)
Jorge Gorbe Moya via llvm-commits
llvm-commits at lists.llvm.org
Tue May 27 09:49:11 PDT 2025
================
@@ -115,7 +115,7 @@ class Region {
Context::CallbackID EraseInstCB;
/// Adds I to the set.
- void add(Instruction *I);
+ void add(Instruction *I, bool TrackScore = true);
----------------
slackito wrote:
If it's private then I'm fine with having an optional arg. Sorry I didn't notice at first.
Nit: booleans with a negative name can be confusing to reason about, I liked `TrackScore` better.
https://github.com/llvm/llvm-project/pull/137443
More information about the llvm-commits
mailing list