[llvm] f64f4f5 - MCELFObjectTargetWriter::needsRelocateWithSymbol: Replace MCSymbol uses with MCValue

Fangrui Song via llvm-commits llvm-commits at lists.llvm.org
Sat May 24 23:45:31 PDT 2025


Author: Fangrui Song
Date: 2025-05-24T23:45:25-07:00
New Revision: f64f4f575fc6897daba41cfc4d2b9064e235c5df

URL: https://github.com/llvm/llvm-project/commit/f64f4f575fc6897daba41cfc4d2b9064e235c5df
DIFF: https://github.com/llvm/llvm-project/commit/f64f4f575fc6897daba41cfc4d2b9064e235c5df.diff

LOG: MCELFObjectTargetWriter::needsRelocateWithSymbol: Replace MCSymbol uses with MCValue

Prepare for removing the MCSymbol argument

Added: 
    

Modified: 
    llvm/lib/Target/PowerPC/MCTargetDesc/PPCELFObjectWriter.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/PowerPC/MCTargetDesc/PPCELFObjectWriter.cpp b/llvm/lib/Target/PowerPC/MCTargetDesc/PPCELFObjectWriter.cpp
index b6707358b2fd7..5f6815d949474 100644
--- a/llvm/lib/Target/PowerPC/MCTargetDesc/PPCELFObjectWriter.cpp
+++ b/llvm/lib/Target/PowerPC/MCTargetDesc/PPCELFObjectWriter.cpp
@@ -486,8 +486,8 @@ unsigned PPCELFObjectWriter::getRelocType(const MCFixup &Fixup,
   return Type;
 }
 
-bool PPCELFObjectWriter::needsRelocateWithSymbol(const MCValue &,
-                                                 const MCSymbol &Sym,
+bool PPCELFObjectWriter::needsRelocateWithSymbol(const MCValue &V,
+                                                 const MCSymbol &,
                                                  unsigned Type) const {
   switch (Type) {
     default:
@@ -500,7 +500,7 @@ bool PPCELFObjectWriter::needsRelocateWithSymbol(const MCValue &,
       // The "other" values are stored in the last 6 bits of the second byte.
       // The traditional defines for STO values assume the full byte and thus
       // the shift to pack it.
-      unsigned Other = cast<MCSymbolELF>(Sym).getOther() << 2;
+      unsigned Other = cast<MCSymbolELF>(*V.getAddSym()).getOther() << 2;
       return (Other & ELF::STO_PPC64_LOCAL_MASK) != 0;
     }
 


        


More information about the llvm-commits mailing list