[llvm] [NewGVN] Precommit test (PR #141362)
via llvm-commits
llvm-commits at lists.llvm.org
Sat May 24 11:31:48 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-llvm-transforms
Author: None (ManuelJBrito)
<details>
<summary>Changes</summary>
Following 14dee0a and 3416d4f the first function gets miscompiled.
---
Full diff: https://github.com/llvm/llvm-project/pull/141362.diff
1 Files Affected:
- (added) llvm/test/Transforms/NewGVN/coercion-different-ptr.ll (+53)
``````````diff
diff --git a/llvm/test/Transforms/NewGVN/coercion-different-ptr.ll b/llvm/test/Transforms/NewGVN/coercion-different-ptr.ll
new file mode 100644
index 0000000000000..c6eb4a2cd179b
--- /dev/null
+++ b/llvm/test/Transforms/NewGVN/coercion-different-ptr.ll
@@ -0,0 +1,53 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 5
+; RUN: opt < %s -passes=newgvn -S | FileCheck %s
+
+
+; FIXME: MemorySSA says that load1 depends on the lifetime start.
+; That's OK since MemorySSA is may-alias; however, NewGVN should
+; check whether the lifetime start *actually* defines the loaded pointer
+; before simplifying to uninitialized memory.
+define void @foo(ptr %arg) {
+; CHECK-LABEL: define void @main(
+; CHECK-SAME: ptr [[ARG:%.*]]) {
+; CHECK-NEXT: [[BB:.*:]]
+; CHECK-NEXT: [[ALLOCA:%.*]] = alloca i8, align 16
+; CHECK-NEXT: call void @llvm.lifetime.start.p0(i64 1, ptr [[ALLOCA]])
+; CHECK-NEXT: [[LOAD:%.*]] = load ptr, ptr [[ARG]], align 8
+; CHECK-NEXT: [[CALL:%.*]] = call ptr undef(ptr [[ALLOCA]])
+; CHECK-NEXT: ret void
+;
+bb:
+ %alloca = alloca i8, align 16
+ call void @llvm.lifetime.start.p0(i64 1, ptr %alloca)
+ %load = load ptr, ptr %arg, align 8
+ %load1 = load ptr, ptr %load, align 8
+ %call = call ptr %load1(ptr %alloca)
+ ret void
+}
+
+declare void @llvm.lifetime.start.p0(i64 immarg, ptr captures(none)) #0
+
+declare ptr @malloc(i64)
+
+; This case is handled correctly.
+; Since malloc returns a pointer, NewGVN checks whether
+; it is the same pointer, an equivalent one, or a must-alias.
+define void @wombat(ptr %arg) {
+; CHECK-LABEL: define void @wombat(
+; CHECK-SAME: ptr [[ARG:%.*]]) {
+; CHECK-NEXT: [[BB:.*:]]
+; CHECK-NEXT: [[CALL:%.*]] = call ptr @malloc(i64 1)
+; CHECK-NEXT: [[LOAD:%.*]] = load ptr, ptr [[ARG]], align 8
+; CHECK-NEXT: [[LOAD1:%.*]] = load ptr, ptr [[LOAD]], align 8
+; CHECK-NEXT: [[CALL2:%.*]] = call ptr [[LOAD1]](ptr [[CALL]])
+; CHECK-NEXT: ret void
+;
+bb:
+ %call = call ptr @malloc(i64 1)
+ %load = load ptr, ptr %arg, align 8
+ %load1 = load ptr, ptr %load, align 8
+ %call2 = call ptr %load1(ptr %call)
+ ret void
+}
+
+attributes #0 = { nocallback nofree nosync nounwind willreturn memory(argmem: readwrite) }
``````````
</details>
https://github.com/llvm/llvm-project/pull/141362
More information about the llvm-commits
mailing list