[llvm] [SandboxIR][Region] Auxiliary vector metadata now requires a region (PR #137443)

Jorge Gorbe Moya via llvm-commits llvm-commits at lists.llvm.org
Fri May 23 19:19:56 PDT 2025


================
@@ -115,7 +115,7 @@ class Region {
   Context::CallbackID EraseInstCB;
 
   /// Adds I to the set.
-  void add(Instruction *I);
+  void add(Instruction *I, bool TrackScore = true);
----------------
slackito wrote:

Please add a comment explaining what's the intended use case for passing `false` here. Actually, if it doesn't make sense outside of `setAux` and `createRegionsFromMD` we could even add a separate overload (instead of a default argument) and make the 2-argument overload private. WDYT?

https://github.com/llvm/llvm-project/pull/137443


More information about the llvm-commits mailing list