[llvm] Extend llvm objdump fatbin (PR #140286)

[David Salinas via llvm-commits]

david-salinas wrote:

> Hi, were seeing test failures from this patch in our CI.
> 
> **Error:**
> 
> ```
> ******************** TEST 'LLVM :: tools/llvm-objdump/Offloading/fatbin.test' FAILED ********************
> Exit Code: 1
> 
> Command Output (stdout):
> --
> 
> /b/s/w/ir/x/w/llvm_build/test/tools/llvm-objdump/Offloading/Output/fatbin.test.tmp.elf:	file format elf64-x86-64
> Extracting offload bundle: /b/s/w/ir/x/w/llvm_build/test/tools/llvm-objdump/Offloading/Output/fatbin.test.tmp.elf.0.host-x86_64-unknown-linux--
> Extracting offload bundle: /b/s/w/ir/x/w/llvm_build/test/tools/llvm-objdump/Offloading/Output/fatbin.test.tmp.elf.0.hipv4-amdgcn-amd-amdhsa--gfx908
> 
> --
> Command Output (stderr):
> --
> /b/s/w/ir/x/w/llvm_build/bin/yaml2obj /b/s/w/ir/x/w/llvm-llvm-project/llvm/test/tools/llvm-objdump/Offloading/fatbin.test -o /b/s/w/ir/x/w/llvm_build/test/tools/llvm-objdump/Offloading/Output/fatbin.test.tmp.elf # RUN: at line 4
> + /b/s/w/ir/x/w/llvm_build/bin/yaml2obj /b/s/w/ir/x/w/llvm-llvm-project/llvm/test/tools/llvm-objdump/Offloading/fatbin.test -o /b/s/w/ir/x/w/llvm_build/test/tools/llvm-objdump/Offloading/Output/fatbin.test.tmp.elf
> /b/s/w/ir/x/w/llvm_build/bin/llvm-objdump --offloading /b/s/w/ir/x/w/llvm_build/test/tools/llvm-objdump/Offloading/Output/fatbin.test.tmp.elf # RUN: at line 5
> + /b/s/w/ir/x/w/llvm_build/bin/llvm-objdump --offloading /b/s/w/ir/x/w/llvm_build/test/tools/llvm-objdump/Offloading/Output/fatbin.test.tmp.elf
> /b/s/w/ir/x/w/llvm_build/bin/llvm-objdump -d /b/s/w/ir/x/w/llvm_build/test/tools/llvm-objdump/Offloading/Output/fatbin.test.tmp.elf.0.hipv4-amdgcn-amd-amdhsa--gfx908 | /b/s/w/ir/x/w/llvm_build/bin/FileCheck /b/s/w/ir/x/w/llvm-llvm-project/llvm/test/tools/llvm-objdump/Offloading/fatbin.test # RUN: at line 6
> + /b/s/w/ir/x/w/llvm_build/bin/llvm-objdump -d /b/s/w/ir/x/w/llvm_build/test/tools/llvm-objdump/Offloading/Output/fatbin.test.tmp.elf.0.hipv4-amdgcn-amd-amdhsa--gfx908
> + /b/s/w/ir/x/w/llvm_build/bin/FileCheck /b/s/w/ir/x/w/llvm-llvm-project/llvm/test/tools/llvm-objdump/Offloading/fatbin.test
> /b/s/w/ir/x/w/llvm_build/bin/llvm-objdump: error: '/b/s/w/ir/x/w/llvm_build/test/tools/llvm-objdump/Offloading/Output/fatbin.test.tmp.elf.0.hipv4-amdgcn-amd-amdhsa--gfx908': can't find target: unable to get target for 'amdgcn-amd-amdhsa', see --version and --triple.
> /b/s/w/ir/x/w/llvm-llvm-project/llvm/test/tools/llvm-objdump/Offloading/fatbin.test:9:10: error: CHECK: expected string not found in input
> # CHECK: s_load_dword s7, s[4:5], 0x24
>          ^
> <stdin>:1:1: note: scanning from here
> 
> ^
> <stdin>:2:51: note: possible intended match here
> /b/s/w/ir/x/w/llvm_build/test/tools/llvm-objdump/Offloading/Output/fatbin.test.tmp.elf.0.hipv4-amdgcn-amd-amdhsa--gfx908: file format elf64-amdgpu
>                                                   ^
> 
> Input file: <stdin>
> Check file: /b/s/w/ir/x/w/llvm-llvm-project/llvm/test/tools/llvm-objdump/Offloading/fatbin.test
> 
> -dump-input=help explains the following input dump.
> 
> Input was:
> <<<<<<
>            1:  
> check:9'0     X error: no match found
>            2: /b/s/w/ir/x/w/llvm_build/test/tools/llvm-objdump/Offloading/Output/fatbin.test.tmp.elf.0.hipv4-amdgcn-amd-amdhsa--gfx908: file format elf64-amdgpu 
> check:9'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> check:9'1                                                       ?                                                                                                 possible intended match
> >>>>>>
> 
> --
> 
> ********************
> ```
> 
> **Bot:** https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/clang-host-linux-x64/b8714066091099918513/overview
> 
> **Log:** https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket/8714066091099918513/+/u/clang/tests/stdout
> 
> If it isn't trivial to fix, would you mind reverting until a fixed version is ready?

hi I believe it is a trivial fix.  I'll post a fix asap.

https://github.com/llvm/llvm-project/pull/140286