[llvm] [LLVM] [NFC] - Remove duplicate #include headers from the files of llvm dir (PR #141057)
Akash Agrawal via llvm-commits
llvm-commits at lists.llvm.org
Thu May 22 21:12:19 PDT 2025
https://github.com/akashagrwl updated https://github.com/llvm/llvm-project/pull/141057
>From 6e0ee6e0bdb53517431d9f07c2aa9ca002a8163c Mon Sep 17 00:00:00 2001
From: Akash Agrawal <akashag at qti.qualcomm.com>
Date: Thu, 22 May 2025 17:50:53 +0530
Subject: [PATCH 1/2] [LLVM] Cleanup - Remove duplicate #include headers from
the files of llvm-project/llvm dir
Change-Id: Ic8ab4160f22730fb7eef6ddc89e04a6b905518ff
---
llvm/lib/IR/ProfDataUtils.cpp | 1 -
llvm/lib/Transforms/IPO/StripSymbols.cpp | 1 -
llvm/tools/llvm-gsymutil/llvm-gsymutil.cpp | 1 -
llvm/tools/llvm-pdbutil/PrettyClassLayoutGraphicalDumper.cpp | 1 -
llvm/unittests/CodeGen/DroppedVariableStatsMIRTest.cpp | 2 --
llvm/unittests/IR/DroppedVariableStatsIRTest.cpp | 2 --
llvm/unittests/Support/ManagedStatic.cpp | 2 --
llvm/unittests/Support/Path.cpp | 1 -
8 files changed, 11 deletions(-)
diff --git a/llvm/lib/IR/ProfDataUtils.cpp b/llvm/lib/IR/ProfDataUtils.cpp
index 9046373414a6c..684aedb2e331f 100644
--- a/llvm/lib/IR/ProfDataUtils.cpp
+++ b/llvm/lib/IR/ProfDataUtils.cpp
@@ -10,7 +10,6 @@
//
//===----------------------------------------------------------------------===//
-#include "llvm/IR/ProfDataUtils.h"
#include "llvm/ADT/SmallVector.h"
#include "llvm/IR/Constants.h"
#include "llvm/IR/Function.h"
diff --git a/llvm/lib/Transforms/IPO/StripSymbols.cpp b/llvm/lib/Transforms/IPO/StripSymbols.cpp
index 647caaa123cf8..5f7f963e25ece 100644
--- a/llvm/lib/Transforms/IPO/StripSymbols.cpp
+++ b/llvm/lib/Transforms/IPO/StripSymbols.cpp
@@ -19,7 +19,6 @@
//
//===----------------------------------------------------------------------===//
-#include "llvm/Transforms/IPO/StripSymbols.h"
#include "llvm/ADT/SmallPtrSet.h"
#include "llvm/IR/Constants.h"
#include "llvm/IR/DebugInfo.h"
diff --git a/llvm/tools/llvm-gsymutil/llvm-gsymutil.cpp b/llvm/tools/llvm-gsymutil/llvm-gsymutil.cpp
index 84934976be2c8..de83a0dc8ebe2 100644
--- a/llvm/tools/llvm-gsymutil/llvm-gsymutil.cpp
+++ b/llvm/tools/llvm-gsymutil/llvm-gsymutil.cpp
@@ -46,7 +46,6 @@
#include "llvm/DebugInfo/GSYM/LookupResult.h"
#include "llvm/DebugInfo/GSYM/ObjectFileTransformer.h"
#include "llvm/DebugInfo/GSYM/OutputAggregator.h"
-#include <optional>
using namespace llvm;
using namespace gsym;
diff --git a/llvm/tools/llvm-pdbutil/PrettyClassLayoutGraphicalDumper.cpp b/llvm/tools/llvm-pdbutil/PrettyClassLayoutGraphicalDumper.cpp
index c42028375b23d..4c8e096477481 100644
--- a/llvm/tools/llvm-pdbutil/PrettyClassLayoutGraphicalDumper.cpp
+++ b/llvm/tools/llvm-pdbutil/PrettyClassLayoutGraphicalDumper.cpp
@@ -13,7 +13,6 @@
#include "PrettyFunctionDumper.h"
#include "PrettyTypedefDumper.h"
#include "PrettyVariableDumper.h"
-#include "PrettyVariableDumper.h"
#include "llvm-pdbutil.h"
#include "llvm/DebugInfo/PDB/IPDBLineNumber.h"
diff --git a/llvm/unittests/CodeGen/DroppedVariableStatsMIRTest.cpp b/llvm/unittests/CodeGen/DroppedVariableStatsMIRTest.cpp
index 91f3d9ccbd655..36504f50505a4 100644
--- a/llvm/unittests/CodeGen/DroppedVariableStatsMIRTest.cpp
+++ b/llvm/unittests/CodeGen/DroppedVariableStatsMIRTest.cpp
@@ -19,10 +19,8 @@
#include "llvm/Support/TargetSelect.h"
#include "llvm/Target/TargetMachine.h"
#include "gtest/gtest.h"
-#include <gtest/gtest.h>
#include <llvm/ADT/SmallString.h>
#include <llvm/IR/LLVMContext.h>
-#include <llvm/IR/Module.h>
#include <llvm/IR/PassInstrumentation.h>
#include <llvm/IR/PassManager.h>
#include <llvm/IR/PassTimingInfo.h>
diff --git a/llvm/unittests/IR/DroppedVariableStatsIRTest.cpp b/llvm/unittests/IR/DroppedVariableStatsIRTest.cpp
index 72d8373fc45df..20c66b93fcb1a 100644
--- a/llvm/unittests/IR/DroppedVariableStatsIRTest.cpp
+++ b/llvm/unittests/IR/DroppedVariableStatsIRTest.cpp
@@ -16,10 +16,8 @@
#include "llvm/Passes/StandardInstrumentations.h"
#include "llvm/Support/SourceMgr.h"
#include "gtest/gtest.h"
-#include <gtest/gtest.h>
#include <llvm/ADT/SmallString.h>
#include <llvm/IR/LLVMContext.h>
-#include <llvm/IR/Module.h>
#include <llvm/IR/PassInstrumentation.h>
#include <llvm/IR/PassManager.h>
#include <llvm/IR/PassTimingInfo.h>
diff --git a/llvm/unittests/Support/ManagedStatic.cpp b/llvm/unittests/Support/ManagedStatic.cpp
index 3463c20252da7..7c102227a3d17 100644
--- a/llvm/unittests/Support/ManagedStatic.cpp
+++ b/llvm/unittests/Support/ManagedStatic.cpp
@@ -15,8 +15,6 @@
#include <pthread.h>
#endif
-#include "gtest/gtest.h"
-
using namespace llvm;
namespace {
diff --git a/llvm/unittests/Support/Path.cpp b/llvm/unittests/Support/Path.cpp
index ef83fcb1950c9..355aa6b9ade06 100644
--- a/llvm/unittests/Support/Path.cpp
+++ b/llvm/unittests/Support/Path.cpp
@@ -11,7 +11,6 @@
#include "llvm/ADT/ScopeExit.h"
#include "llvm/ADT/SmallVector.h"
#include "llvm/BinaryFormat/Magic.h"
-#include "llvm/Config/llvm-config.h"
#include "llvm/Config/llvm-config.h" // for LLVM_ON_UNIX
#include "llvm/Support/Compiler.h"
#include "llvm/Support/ConvertUTF.h"
>From 823352927fc5819895c6366247580748f7c48fca Mon Sep 17 00:00:00 2001
From: Akash Agrawal <akashag at qti.qualcomm.com>
Date: Fri, 23 May 2025 09:40:00 +0530
Subject: [PATCH 2/2] Addressing comments - Adding the main module header file
at top & removed other instance
Change-Id: Ib9c54d7e7ff459d69df90e1783b5a6860d1d2907
---
llvm/lib/IR/ProfDataUtils.cpp | 3 ++-
llvm/lib/Transforms/IPO/StripSymbols.cpp | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/llvm/lib/IR/ProfDataUtils.cpp b/llvm/lib/IR/ProfDataUtils.cpp
index 684aedb2e331f..21524eb840539 100644
--- a/llvm/lib/IR/ProfDataUtils.cpp
+++ b/llvm/lib/IR/ProfDataUtils.cpp
@@ -10,6 +10,8 @@
//
//===----------------------------------------------------------------------===//
+#include "llvm/IR/ProfDataUtils.h"
+
#include "llvm/ADT/SmallVector.h"
#include "llvm/IR/Constants.h"
#include "llvm/IR/Function.h"
@@ -17,7 +19,6 @@
#include "llvm/IR/LLVMContext.h"
#include "llvm/IR/MDBuilder.h"
#include "llvm/IR/Metadata.h"
-#include "llvm/IR/ProfDataUtils.h"
using namespace llvm;
diff --git a/llvm/lib/Transforms/IPO/StripSymbols.cpp b/llvm/lib/Transforms/IPO/StripSymbols.cpp
index 5f7f963e25ece..78bcd8b83bd28 100644
--- a/llvm/lib/Transforms/IPO/StripSymbols.cpp
+++ b/llvm/lib/Transforms/IPO/StripSymbols.cpp
@@ -19,6 +19,8 @@
//
//===----------------------------------------------------------------------===//
+#include "llvm/Transforms/IPO/StripSymbols.h"
+
#include "llvm/ADT/SmallPtrSet.h"
#include "llvm/IR/Constants.h"
#include "llvm/IR/DebugInfo.h"
@@ -32,7 +34,6 @@
#include "llvm/IR/ValueSymbolTable.h"
#include "llvm/Support/Casting.h"
#include "llvm/Support/CommandLine.h"
-#include "llvm/Transforms/IPO/StripSymbols.h"
#include "llvm/Transforms/Utils/Local.h"
using namespace llvm;
More information about the llvm-commits
mailing list