[llvm] [llvm] Use llvm::erase_if (NFC) (PR #141185)

Kazu Hirata via llvm-commits llvm-commits at lists.llvm.org
Thu May 22 19:19:00 PDT 2025


https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/141185

None

>From bdc29e36d649e9f847bbafbb2d631e5e3442a377 Mon Sep 17 00:00:00 2001
From: Kazu Hirata <kazu at google.com>
Date: Wed, 21 May 2025 20:42:03 -0700
Subject: [PATCH] [llvm] Use llvm::erase_if (NFC)

---
 llvm/unittests/TargetParser/CSKYTargetParserTest.cpp | 7 ++-----
 llvm/unittests/TargetParser/TargetParserTest.cpp     | 7 ++-----
 llvm/unittests/TextAPI/TextStubHelpers.h             | 2 +-
 3 files changed, 5 insertions(+), 11 deletions(-)

diff --git a/llvm/unittests/TargetParser/CSKYTargetParserTest.cpp b/llvm/unittests/TargetParser/CSKYTargetParserTest.cpp
index 50e825c5f99fe..57e1aff1df81c 100644
--- a/llvm/unittests/TargetParser/CSKYTargetParserTest.cpp
+++ b/llvm/unittests/TargetParser/CSKYTargetParserTest.cpp
@@ -26,11 +26,8 @@ std::string FormatExtensionFlags(uint64_t Flags) {
     Features.push_back("none");
   CSKY::getExtensionFeatures(Flags, Features);
 
-  Features.erase(std::remove_if(Features.begin(), Features.end(),
-                                [](StringRef extension) {
-                                  return extension.starts_with("-");
-                                }),
-                 Features.end());
+  llvm::erase_if(
+      Features, [](StringRef extension) { return extension.starts_with("-"); });
 
   return llvm::join(Features, ", ");
 }
diff --git a/llvm/unittests/TargetParser/TargetParserTest.cpp b/llvm/unittests/TargetParser/TargetParserTest.cpp
index 0b1c84e6311ba..f4c93334ac682 100644
--- a/llvm/unittests/TargetParser/TargetParserTest.cpp
+++ b/llvm/unittests/TargetParser/TargetParserTest.cpp
@@ -58,11 +58,8 @@ std::string FormatExtensionFlags(int64_t Flags) {
 
   // The target parser also includes every extension you don't have.
   // E.g. if AEK_CRC is not set then it adds "-crc". Not useful here.
-  Features.erase(std::remove_if(Features.begin(), Features.end(),
-                                [](StringRef extension) {
-                                  return extension.starts_with("-");
-                                }),
-                 Features.end());
+  llvm::erase_if(
+      Features, [](StringRef extension) { return extension.starts_with("-"); });
 
   return llvm::join(Features, ", ");
 }
diff --git a/llvm/unittests/TextAPI/TextStubHelpers.h b/llvm/unittests/TextAPI/TextStubHelpers.h
index baefe8fa9bbf9..7c9c74a252760 100644
--- a/llvm/unittests/TextAPI/TextStubHelpers.h
+++ b/llvm/unittests/TextAPI/TextStubHelpers.h
@@ -39,7 +39,7 @@ inline bool operator==(const ExportedSymbol &LHS, const ExportedSymbol &RHS) {
 }
 
 inline std::string stripWhitespace(std::string S) {
-  S.erase(std::remove_if(S.begin(), S.end(), ::isspace), S.end());
+  llvm::erase_if(S, ::isspace);
   return S;
 }
 



More information about the llvm-commits mailing list