[llvm] [flang-rt] Optimise ShallowCopy and use it in CopyInAssign (PR #140569)

Thu May 22 07:47:02 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `amdgpu-offload-ubuntu-22-cmake-build-only` running on `rocm-docker-ubu-22` while building `flang-rt` at step 4 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/203/builds/11299

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 4 (annotate) failure: '../llvm-zorg/zorg/buildbot/builders/annotated/amdgpu-offload-cmake.py --jobs=32' (failure)
...
[28/91] Building LLVM bitcode State.cpp-amdgpu.o
[29/91] Linking CXX shared library /home/botworker/bbot/amdgpu-offload-ubuntu-22-cmake-build-only/build/lib/clang/21/lib/x86_64-unknown-linux-gnu/libclang_rt.memprof.so
[30/91] Generating /home/botworker/bbot/amdgpu-offload-ubuntu-22-cmake-build-only/build/compile_commands.json
[31/91] Linking CXX executable /home/botworker/bbot/amdgpu-offload-ubuntu-22-cmake-build-only/build/bin/llvm-omp-kernel-replay
[32/91] Linking CXX executable /home/botworker/bbot/amdgpu-offload-ubuntu-22-cmake-build-only/build/bin/llvm-offload-device-info
[33/91] Building LLVM bitcode Parallelism.cpp-amdgpu.o
[34/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/allocatable.cpp.o
[35/91] Building LLVM bitcode Workshare.cpp-amdgpu.o
[36/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/copy.cpp.o
[37/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/assign.cpp.o
FAILED: flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/assign.cpp.o 
/home/botworker/bbot/amdgpu-offload-ubuntu-22-cmake-build-only/build/./bin/clang++ --target=x86_64-unknown-linux-gnu -D_DEBUG -D_GLIBCXX_ASSERTIONS -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/botworker/bbot/amdgpu-offload-ubuntu-22-cmake-build-only/llvm-project/flang-rt/include -I/home/botworker/bbot/amdgpu-offload-ubuntu-22-cmake-build-only/llvm-project/flang-rt/../flang/include -I/home/botworker/bbot/amdgpu-offload-ubuntu-22-cmake-build-only/build/runtimes/runtimes-bins/flang-rt -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wno-unnecessary-virtual-specifier -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -UNDEBUG -fno-lto -fno-exceptions -fno-rtti -funwind-tables -fno-asynchronous-unwind-tables -U_GLIBCXX_ASSERTIONS -U_LIBCPP_ENABLE_ASSERTIONS -std=gnu++17 -MD -MT flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/assign.cpp.o -MF flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/assign.cpp.o.d -o flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/assign.cpp.o -c /home/botworker/bbot/amdgpu-offload-ubuntu-22-cmake-build-only/llvm-project/flang-rt/lib/runtime/assign.cpp
/home/botworker/bbot/amdgpu-offload-ubuntu-22-cmake-build-only/llvm-project/flang-rt/lib/runtime/assign.cpp:594:17: error: use of undeclared identifier 'kNoAsyncId'
  594 |   temp.Allocate(kNoAsyncId);
      |                 ^~~~~~~~~~
1 error generated.
[38/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/ISO_Fortran_binding.cpp.o
[39/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/descriptor.cpp.o
[40/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/connection.cpp.o
[41/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/internal-unit.cpp.o
[42/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/environment.cpp.o
[43/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/array-constructor.cpp.o
[44/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/non-tbp-dio.cpp.o
[45/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/file.cpp.o
[46/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/memory.cpp.o
[47/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/derived.cpp.o
[48/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/derived-api.cpp.o
[49/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/io-error.cpp.o
[50/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/misc-intrinsic.cpp.o
[51/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/inquiry.cpp.o
[52/91] Linking CXX executable /home/botworker/bbot/amdgpu-offload-ubuntu-22-cmake-build-only/build/lib/libomptarget-amdgpu.bc
clang++: warning: joined argument expects additional value: '-mcpu=' [-Wunused-command-line-argument]
[53/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/pointer.cpp.o
[54/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/edit-input.cpp.o
[55/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/numeric.cpp.o
[56/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/descriptor-io.cpp.o
[57/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/external-unit.cpp.o
[58/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/io-api-minimal.cpp.o
[59/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/format.cpp.o
[60/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/edit-output.cpp.o
[61/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/io-stmt.cpp.o
[62/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/product.cpp.o
[63/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/namelist.cpp.o
[64/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/io-api.cpp.o
[65/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/character.cpp.o
[66/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/dot-product.cpp.o
[67/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/extrema.cpp.o
[68/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/matmul-transpose.cpp.o
[69/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/matmul.cpp.o
Step 7 (build cmake config) failure: build cmake config (failure)
...
[28/91] Building LLVM bitcode State.cpp-amdgpu.o
[29/91] Linking CXX shared library /home/botworker/bbot/amdgpu-offload-ubuntu-22-cmake-build-only/build/lib/clang/21/lib/x86_64-unknown-linux-gnu/libclang_rt.memprof.so
[30/91] Generating /home/botworker/bbot/amdgpu-offload-ubuntu-22-cmake-build-only/build/compile_commands.json
[31/91] Linking CXX executable /home/botworker/bbot/amdgpu-offload-ubuntu-22-cmake-build-only/build/bin/llvm-omp-kernel-replay
[32/91] Linking CXX executable /home/botworker/bbot/amdgpu-offload-ubuntu-22-cmake-build-only/build/bin/llvm-offload-device-info
[33/91] Building LLVM bitcode Parallelism.cpp-amdgpu.o
[34/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/allocatable.cpp.o
[35/91] Building LLVM bitcode Workshare.cpp-amdgpu.o
[36/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/copy.cpp.o
[37/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/assign.cpp.o
FAILED: flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/assign.cpp.o 
/home/botworker/bbot/amdgpu-offload-ubuntu-22-cmake-build-only/build/./bin/clang++ --target=x86_64-unknown-linux-gnu -D_DEBUG -D_GLIBCXX_ASSERTIONS -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/botworker/bbot/amdgpu-offload-ubuntu-22-cmake-build-only/llvm-project/flang-rt/include -I/home/botworker/bbot/amdgpu-offload-ubuntu-22-cmake-build-only/llvm-project/flang-rt/../flang/include -I/home/botworker/bbot/amdgpu-offload-ubuntu-22-cmake-build-only/build/runtimes/runtimes-bins/flang-rt -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wno-unnecessary-virtual-specifier -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -UNDEBUG -fno-lto -fno-exceptions -fno-rtti -funwind-tables -fno-asynchronous-unwind-tables -U_GLIBCXX_ASSERTIONS -U_LIBCPP_ENABLE_ASSERTIONS -std=gnu++17 -MD -MT flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/assign.cpp.o -MF flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/assign.cpp.o.d -o flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/assign.cpp.o -c /home/botworker/bbot/amdgpu-offload-ubuntu-22-cmake-build-only/llvm-project/flang-rt/lib/runtime/assign.cpp
/home/botworker/bbot/amdgpu-offload-ubuntu-22-cmake-build-only/llvm-project/flang-rt/lib/runtime/assign.cpp:594:17: error: use of undeclared identifier 'kNoAsyncId'
  594 |   temp.Allocate(kNoAsyncId);
      |                 ^~~~~~~~~~
1 error generated.
[38/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/ISO_Fortran_binding.cpp.o
[39/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/descriptor.cpp.o
[40/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/connection.cpp.o
[41/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/internal-unit.cpp.o
[42/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/environment.cpp.o
[43/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/array-constructor.cpp.o
[44/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/non-tbp-dio.cpp.o
[45/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/file.cpp.o
[46/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/memory.cpp.o
[47/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/derived.cpp.o
[48/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/derived-api.cpp.o
[49/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/io-error.cpp.o
[50/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/misc-intrinsic.cpp.o
[51/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/inquiry.cpp.o
[52/91] Linking CXX executable /home/botworker/bbot/amdgpu-offload-ubuntu-22-cmake-build-only/build/lib/libomptarget-amdgpu.bc
clang++: warning: joined argument expects additional value: '-mcpu=' [-Wunused-command-line-argument]
[53/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/pointer.cpp.o
[54/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/edit-input.cpp.o
[55/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/numeric.cpp.o
[56/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/descriptor-io.cpp.o
[57/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/external-unit.cpp.o
[58/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/io-api-minimal.cpp.o
[59/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/format.cpp.o
[60/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/edit-output.cpp.o
[61/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/io-stmt.cpp.o
[62/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/product.cpp.o
[63/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/namelist.cpp.o
[64/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/io-api.cpp.o
[65/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/character.cpp.o
[66/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/dot-product.cpp.o
[67/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/extrema.cpp.o
[68/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/matmul-transpose.cpp.o
[69/91] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/matmul.cpp.o

```

</details>

https://github.com/llvm/llvm-project/pull/140569