[llvm] [InstCombine] Iterative replacement in PtrReplacer (PR #137215)

[Matt Arsenault via llvm-commits]

================
@@ -365,12 +411,20 @@ void PointerReplacer::replace(Instruction *I) {
     // replacement (new value).
     WorkMap[NewI] = NewI;
   } else if (auto *PHI = dyn_cast<PHINode>(I)) {
-    Type *NewTy = getReplacement(PHI->getIncomingValue(0))->getType();
-    auto *NewPHI = PHINode::Create(NewTy, PHI->getNumIncomingValues(),
-                                   PHI->getName(), PHI->getIterator());
+    // Create a new PHI by replacing any incoming value that is a user of the
+    // root pointer and has a replacement.
+    SmallVector<Value *, 4> IncomingValues;
+    for (unsigned int I = 0; I < PHI->getNumIncomingValues(); ++I) {
----------------
arsenm wrote:

Use range loop? 

https://github.com/llvm/llvm-project/pull/137215