[llvm] [CodeGen] Avoid MachineModuleInfo in MachineModuleSlotTracker (PR #140530)
Akshat Oke via llvm-commits
llvm-commits at lists.llvm.org
Wed May 21 23:30:29 PDT 2025
optimisan wrote:
We moved from having a MF analysis (in legacy) to MMI to support Module passes in codegen pipeline.
In NPM we are moving back to MF analysis (in NPM) and this patch is to complete the last transition.
I don't see any new developments in this area, so
> > In NPM, MMI is not used to store machine functions so we need to use the analysis manager here.
>
> This sounds broken. MachineModuleInfo is supposed to merely be the map from Function to MachineFunction. The NewPM (and other PM-less uses) should still use it
is mostly contradicting https://github.com/llvm/llvm-project/pull/88610#pullrequestreview-2000656280: "Moving things out of MMI is good"
https://github.com/llvm/llvm-project/pull/140530
More information about the llvm-commits
mailing list