[llvm] fb627e3 - [LLVM][IR] Replace `unsigned >= ConstantDataFirstVal` with static_assert (#140827)

[via llvm-commits]

Author: Rahul Joshi
Date: 2025-05-21T06:23:37-07:00
New Revision: fb627e39e28ab5f72a90d00e60d2e80ff8482c6f

URL: https://github.com/llvm/llvm-project/commit/fb627e39e28ab5f72a90d00e60d2e80ff8482c6f
DIFF: https://github.com/llvm/llvm-project/commit/fb627e39e28ab5f72a90d00e60d2e80ff8482c6f.diff

LOG: [LLVM][IR] Replace `unsigned >= ConstantDataFirstVal` with static_assert (#140827)

`ConstantDataFirstVal` is 0, so `getValueID() >= ConstantDataFirstVal`
leads to a compiler warning that the expression is always true. Replace
such comparisons with a static_assert() to verify that
`ConstantDataFirstVal` is 0, similar to the existing code in Value.h

Added: 
    

Modified: 
    llvm/include/llvm/IR/Constants.h
    llvm/include/llvm/IR/Value.h

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/IR/Constants.h b/llvm/include/llvm/IR/Constants.h
index 7137c699cc992..6a01e8209071d 100644
--- a/llvm/include/llvm/IR/Constants.h
+++ b/llvm/include/llvm/IR/Constants.h
@@ -74,8 +74,9 @@ class ConstantData : public Constant {
 
   /// Methods to support type inquiry through isa, cast, and dyn_cast.
   static bool classof(const Value *V) {
-    return V->getValueID() >= ConstantDataFirstVal &&
-           V->getValueID() <= ConstantDataLastVal;
+    static_assert(Value::ConstantDataFirstVal == 0,
+                  "V->getValueID() >= Value::ConstantDataFirstVal");
+    return V->getValueID() <= ConstantDataLastVal;
   }
 };
 

diff  --git a/llvm/include/llvm/IR/Value.h b/llvm/include/llvm/IR/Value.h
index c276899e673a3..999eeb3dad874 100644
--- a/llvm/include/llvm/IR/Value.h
+++ b/llvm/include/llvm/IR/Value.h
@@ -987,15 +987,17 @@ template <class Compare> void Value::sortUseList(Compare Cmp) {
 //
 template <> struct isa_impl<Constant, Value> {
   static inline bool doit(const Value &Val) {
-    static_assert(Value::ConstantFirstVal == 0, "Val.getValueID() >= Value::ConstantFirstVal");
+    static_assert(Value::ConstantFirstVal == 0,
+                  "Val.getValueID() >= Value::ConstantFirstVal");
     return Val.getValueID() <= Value::ConstantLastVal;
   }
 };
 
 template <> struct isa_impl<ConstantData, Value> {
   static inline bool doit(const Value &Val) {
-    return Val.getValueID() >= Value::ConstantDataFirstVal &&
-           Val.getValueID() <= Value::ConstantDataLastVal;
+    static_assert(Value::ConstantDataFirstVal == 0,
+                  "Val.getValueID() >= Value::ConstantDataFirstVal");
+    return Val.getValueID() <= Value::ConstantDataLastVal;
   }
 };