[llvm] [AMDGPU][MISched] Allow memory ops of different base pointers to be clustered (PR #140674)
Jay Foad via llvm-commits
llvm-commits at lists.llvm.org
Wed May 21 03:07:53 PDT 2025
================
@@ -47,6 +47,11 @@ namespace llvm::AMDGPU {
#include "AMDGPUGenSearchableTables.inc"
} // namespace llvm::AMDGPU
+static cl::opt<bool> DisableDiffBasePtrMemClustering(
+ "amdgpu-disable-diff-baseptr-mem-clustering",
+ cl::desc("Disable clustering memory ops with different base pointers"),
+ cl::init(false), cl::Hidden);
----------------
jayfoad wrote:
I would much prefer an "enable" flag. Otherwise you have to parse a double negative to understand what `-disable-thing=false` means.
```suggestion
static cl::opt<bool> EnableDiffBasePtrMemClustering(
"amdgpu-disable-diff-baseptr-mem-clustering",
cl::desc("Disable clustering memory ops with different base pointers"),
cl::init(true), cl::Hidden);
```
https://github.com/llvm/llvm-project/pull/140674
More information about the llvm-commits
mailing list