[llvm] [llvm-remarkutil] Add an instruction-mix tool (PR #140598)

via llvm-commits llvm-commits at lists.llvm.org
Tue May 20 18:18:26 PDT 2025


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp,h -- llvm/tools/llvm-remarkutil/RemarkInstructionMix.cpp llvm/tools/llvm-remarkutil/RemarkCounter.cpp llvm/tools/llvm-remarkutil/RemarkCounter.h llvm/tools/llvm-remarkutil/RemarkUtilHelpers.h
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/tools/llvm-remarkutil/RemarkCounter.cpp b/llvm/tools/llvm-remarkutil/RemarkCounter.cpp
index eb5590693..8db8a8d1b 100644
--- a/llvm/tools/llvm-remarkutil/RemarkCounter.cpp
+++ b/llvm/tools/llvm-remarkutil/RemarkCounter.cpp
@@ -239,7 +239,7 @@ Expected<Filters> getRemarkFilter() {
   std::optional<FilterMatcher> RemarkNameFilter;
   if (!RemarkNameOpt.empty())
     RemarkNameFilter = FilterMatcher::createExact(RemarkNameOpt);
-  else if (!RemarkNameOptRE.empty()){
+  else if (!RemarkNameOptRE.empty()) {
     auto FM = FilterMatcher::createRE(RemarkNameOptRE, "rremark-name");
     if (!FM)
       return FM.takeError();
@@ -325,7 +325,8 @@ static Error collectRemarks() {
         ArgumentsVector.push_back(std::move(*FM));
       }
     else
-      ArgumentsVector.push_back(cantFail(FilterMatcher::createRE(".*", "count-by")));
+      ArgumentsVector.push_back(
+          cantFail(FilterMatcher::createRE(".*", "count-by")));
 
     Expected<ArgumentCounter> AC = ArgumentCounter::createArgumentCounter(
         GroupByOpt, ArgumentsVector, Buffer, Filter);
diff --git a/llvm/tools/llvm-remarkutil/RemarkUtilHelpers.h b/llvm/tools/llvm-remarkutil/RemarkUtilHelpers.h
index 2cf187f4d..31a64ce66 100644
--- a/llvm/tools/llvm-remarkutil/RemarkUtilHelpers.h
+++ b/llvm/tools/llvm-remarkutil/RemarkUtilHelpers.h
@@ -68,11 +68,10 @@ class FilterMatcher {
       : FilterRE(Filter), FilterStr(Filter), IsRegex(IsRegex) {}
 
 public:
-  static FilterMatcher createExact(StringRef Filter) {
-    return {Filter, false};
-  }
+  static FilterMatcher createExact(StringRef Filter) { return {Filter, false}; }
 
-  static Expected<FilterMatcher> createRE(StringRef Filter, StringRef Argument) {
+  static Expected<FilterMatcher> createRE(StringRef Filter,
+                                          StringRef Argument) {
     FilterMatcher FM(Filter, true);
     std::string Error;
     if (!FM.FilterRE.isValid(Error))

``````````

</details>


https://github.com/llvm/llvm-project/pull/140598


More information about the llvm-commits mailing list