[llvm] [Offload] Make OffloadAPI error messages more readable (PR #140728)
via llvm-commits
llvm-commits at lists.llvm.org
Tue May 20 06:17:50 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-offload
Author: Ross Brunton (RossBrunton)
<details>
<summary>Changes</summary>
---
Full diff: https://github.com/llvm/llvm-project/pull/140728.diff
1 Files Affected:
- (modified) offload/unittests/OffloadAPI/common/Fixtures.hpp (+8-1)
``````````diff
diff --git a/offload/unittests/OffloadAPI/common/Fixtures.hpp b/offload/unittests/OffloadAPI/common/Fixtures.hpp
index 2303601feb933..ff3c1f4194807 100644
--- a/offload/unittests/OffloadAPI/common/Fixtures.hpp
+++ b/offload/unittests/OffloadAPI/common/Fixtures.hpp
@@ -15,7 +15,14 @@
#pragma once
#ifndef ASSERT_SUCCESS
-#define ASSERT_SUCCESS(ACTUAL) ASSERT_EQ(OL_SUCCESS, ACTUAL)
+#define ASSERT_SUCCESS(ACTUAL) \
+ do { \
+ ol_result_t Res = ACTUAL; \
+ if (Res && Res->Code != OL_ERRC_SUCCESS) { \
+ GTEST_FAIL() << #ACTUAL " returned " << Res->Code << ": " \
+ << Res->Details; \
+ } \
+ } while (0)
#endif
// TODO: rework this so the EXPECTED/ACTUAL results are readable
``````````
</details>
https://github.com/llvm/llvm-project/pull/140728
More information about the llvm-commits
mailing list