[llvm] [NFC][MemProf] Move types shared between Analysis, ProfileData and ModuleSummary (Core) to a separate header (PR #140505)

Mon May 19 20:20:01 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `clang-ppc64le-linux-multistage` running on `ppc64le-clang-multistage-test` while building `llvm` at step 4 "build stage 1".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/76/builds/9719

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 4 (build stage 1) failure: 'ninja' (failure)
...
[5477/6401] Linking CXX shared library lib/libLLVMDebuginfod.so.21.0git
[5478/6401] Creating library symlink lib/libLLVMDebuginfod.so
[5479/6401] Linking CXX shared library lib/libLLVMCFIVerify.so.21.0git
[5480/6401] Creating library symlink lib/libLLVMCFIVerify.so
[5481/6401] Linking CXX executable bin/llvm-xray
[5482/6401] Linking CXX executable bin/llvm-symbolizer
[5483/6401] Linking CXX executable bin/llvm-debuginfod-find
[5484/6401] Generating ../../bin/llvm-addr2line
[5485/6401] Linking CXX executable bin/llvm-debuginfod
[5486/6401] Linking CXX shared library lib/libLLVMProfileData.so.21.0git
FAILED: lib/libLLVMProfileData.so.21.0git 
: && /usr/lib64/ccache/c++ -fPIC -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-noexcept-type -Wno-unnecessary-virtual-specifier -Wdelete-non-virtual-dtor -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -Wl,-z,defs -Wl,-z,nodelete   -Wl,-rpath-link,/home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-multistage-test/clang-ppc64le-multistage/stage1/./lib  -Wl,--gc-sections -shared -Wl,-soname,libLLVMProfileData.so.21.0git -o lib/libLLVMProfileData.so.21.0git lib/ProfileData/CMakeFiles/LLVMProfileData.dir/DataAccessProf.cpp.o lib/ProfileData/CMakeFiles/LLVMProfileData.dir/GCOV.cpp.o lib/ProfileData/CMakeFiles/LLVMProfileData.dir/IndexedMemProfData.cpp.o lib/ProfileData/CMakeFiles/LLVMProfileData.dir/InstrProf.cpp.o lib/ProfileData/CMakeFiles/LLVMProfileData.dir/InstrProfCorrelator.cpp.o lib/ProfileData/CMakeFiles/LLVMProfileData.dir/InstrProfReader.cpp.o lib/ProfileData/CMakeFiles/LLVMProfileData.dir/InstrProfWriter.cpp.o lib/ProfileData/CMakeFiles/LLVMProfileData.dir/ItaniumManglingCanonicalizer.cpp.o lib/ProfileData/CMakeFiles/LLVMProfileData.dir/MemProf.cpp.o lib/ProfileData/CMakeFiles/LLVMProfileData.dir/MemProfReader.cpp.o lib/ProfileData/CMakeFiles/LLVMProfileData.dir/MemProfRadixTree.cpp.o lib/ProfileData/CMakeFiles/LLVMProfileData.dir/PGOCtxProfReader.cpp.o lib/ProfileData/CMakeFiles/LLVMProfileData.dir/PGOCtxProfWriter.cpp.o lib/ProfileData/CMakeFiles/LLVMProfileData.dir/ProfileSummaryBuilder.cpp.o lib/ProfileData/CMakeFiles/LLVMProfileData.dir/SampleProf.cpp.o lib/ProfileData/CMakeFiles/LLVMProfileData.dir/SampleProfReader.cpp.o lib/ProfileData/CMakeFiles/LLVMProfileData.dir/SampleProfWriter.cpp.o lib/ProfileData/CMakeFiles/LLVMProfileData.dir/SymbolRemappingReader.cpp.o  -Wl,-rpath,"\$ORIGIN/../lib:/home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-multistage-test/clang-ppc64le-multistage/stage1/lib:"  lib/libLLVMSymbolize.so.21.0git  lib/libLLVMDebugInfoDWARF.so.21.0git  lib/libLLVMObject.so.21.0git  lib/libLLVMBitstreamReader.so.21.0git  lib/libLLVMTargetParser.so.21.0git  lib/libLLVMSupport.so.21.0git  lib/libLLVMDemangle.so.21.0git  -Wl,-rpath-link,/home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-multistage-test/clang-ppc64le-multistage/stage1/lib && :
lib/ProfileData/CMakeFiles/LLVMProfileData.dir/InstrProf.cpp.o: In function `llvm::createPGONameMetadata(llvm::GlobalObject&, llvm::StringRef, llvm::StringRef)':
InstrProf.cpp:(.text._ZN4llvmL21createPGONameMetadataERNS_12GlobalObjectENS_9StringRefES2_+0x3c): undefined reference to `llvm::Value::getName() const'
InstrProf.cpp:(.text._ZN4llvmL21createPGONameMetadataERNS_12GlobalObjectENS_9StringRefES2_+0x78): undefined reference to `llvm::Value::getMetadata(llvm::StringRef) const'
InstrProf.cpp:(.text._ZN4llvmL21createPGONameMetadataERNS_12GlobalObjectENS_9StringRefES2_+0xb8): undefined reference to `llvm::Value::getContext() const'
InstrProf.cpp:(.text._ZN4llvmL21createPGONameMetadataERNS_12GlobalObjectENS_9StringRefES2_+0xcc): undefined reference to `llvm::MDString::get(llvm::LLVMContext&, llvm::StringRef)'
InstrProf.cpp:(.text._ZN4llvmL21createPGONameMetadataERNS_12GlobalObjectENS_9StringRefES2_+0xec): undefined reference to `llvm::MDTuple::getImpl(llvm::LLVMContext&, llvm::ArrayRef<llvm::Metadata*>, llvm::Metadata::StorageType, bool)'
InstrProf.cpp:(.text._ZN4llvmL21createPGONameMetadataERNS_12GlobalObjectENS_9StringRefES2_+0x104): undefined reference to `llvm::Value::setMetadata(llvm::StringRef, llvm::MDNode*)'
lib/ProfileData/CMakeFiles/LLVMProfileData.dir/InstrProf.cpp.o: In function `llvm::lookupPGONameFromMetadata(llvm::MDNode*)':
InstrProf.cpp:(.text._ZN4llvmL25lookupPGONameFromMetadataEPNS_6MDNodeE+0x50): undefined reference to `llvm::MDString::getString() const'
lib/ProfileData/CMakeFiles/LLVMProfileData.dir/InstrProf.cpp.o: In function `llvm::getIRPGOObjectName(llvm::GlobalObject const&, bool, llvm::MDNode*)':
InstrProf.cpp:(.text._ZN4llvmL18getIRPGOObjectNameERKNS_12GlobalObjectEbPNS_6MDNodeE+0x50): undefined reference to `llvm::Value::getName() const'
InstrProf.cpp:(.text._ZN4llvmL18getIRPGOObjectNameERKNS_12GlobalObjectEbPNS_6MDNodeE+0x70): undefined reference to `llvm::GlobalValue::getGlobalIdentifier[abi:cxx11](llvm::StringRef, llvm::GlobalValue::LinkageTypes, llvm::StringRef)'
InstrProf.cpp:(.text._ZN4llvmL18getIRPGOObjectNameERKNS_12GlobalObjectEbPNS_6MDNodeE+0x124): undefined reference to `llvm::Value::getName() const'
lib/ProfileData/CMakeFiles/LLVMProfileData.dir/InstrProf.cpp.o: In function `llvm::getIRPGOFuncName[abi:cxx11](llvm::Function const&, bool)':
InstrProf.cpp:(.text._ZN4llvm16getIRPGOFuncNameB5cxx11ERKNS_8FunctionEb+0x50): undefined reference to `llvm::Value::getMetadata(llvm::StringRef) const'
lib/ProfileData/CMakeFiles/LLVMProfileData.dir/InstrProf.cpp.o: In function `llvm::getPGOName[abi:cxx11](llvm::GlobalVariable const&, bool)':
InstrProf.cpp:(.text._ZN4llvm10getPGONameB5cxx11ERKNS_14GlobalVariableEb+0x50): undefined reference to `llvm::Value::getMetadata(llvm::StringRef) const'
lib/ProfileData/CMakeFiles/LLVMProfileData.dir/InstrProf.cpp.o: In function `llvm::getPGOFuncNameVarInitializer(llvm::GlobalVariable*) [clone .localalias.22]':
InstrProf.cpp:(.text._ZN4llvm28getPGOFuncNameVarInitializerEPNS_14GlobalVariableE+0x1c): undefined reference to `llvm::GlobalValue::isDeclaration() const'
InstrProf.cpp:(.text._ZN4llvm28getPGOFuncNameVarInitializerEPNS_14GlobalVariableE+0x48): undefined reference to `llvm::ConstantDataSequential::isCString() const'
InstrProf.cpp:(.text._ZN4llvm28getPGOFuncNameVarInitializerEPNS_14GlobalVariableE+0x5c): undefined reference to `llvm::ConstantDataSequential::isCString() const'
InstrProf.cpp:(.text._ZN4llvm28getPGOFuncNameVarInitializerEPNS_14GlobalVariableE+0x74): undefined reference to `llvm::ConstantDataSequential::isString(unsigned int) const'
InstrProf.cpp:(.text._ZN4llvm28getPGOFuncNameVarInitializerEPNS_14GlobalVariableE+0x88): undefined reference to `llvm::ConstantDataSequential::getRawDataValues() const'
InstrProf.cpp:(.text._ZN4llvm28getPGOFuncNameVarInitializerEPNS_14GlobalVariableE+0xc8): undefined reference to `llvm::ConstantDataSequential::isString(unsigned int) const'
InstrProf.cpp:(.text._ZN4llvm28getPGOFuncNameVarInitializerEPNS_14GlobalVariableE+0xdc): undefined reference to `llvm::ConstantDataSequential::getRawDataValues() const'
lib/ProfileData/CMakeFiles/LLVMProfileData.dir/InstrProf.cpp.o: In function `llvm::getPGOFuncNameMetadata(llvm::Function const&) [clone .localalias.3]':
InstrProf.cpp:(.text._ZN4llvm22getPGOFuncNameMetadataERKNS_8FunctionE+0x40): undefined reference to `llvm::Value::getMetadata(llvm::StringRef) const'
lib/ProfileData/CMakeFiles/LLVMProfileData.dir/InstrProf.cpp.o: In function `llvm::isIRPGOFlagSet(llvm::Module const*)':
InstrProf.cpp:(.text._ZN4llvm14isIRPGOFlagSetEPKNS_6ModuleE+0x44): undefined reference to `llvm::Module::getGlobalVariable(llvm::StringRef, bool) const'
InstrProf.cpp:(.text._ZN4llvm14isIRPGOFlagSetEPKNS_6ModuleE+0x68): undefined reference to `llvm::GlobalValue::isDeclaration() const'
InstrProf.cpp:(.text._ZN4llvm14isIRPGOFlagSetEPKNS_6ModuleE+0x94): undefined reference to `llvm::GlobalValue::isDeclaration() const'
InstrProf.cpp:(.text._ZN4llvm14isIRPGOFlagSetEPKNS_6ModuleE+0xa8): undefined reference to `llvm::GlobalValue::isDeclaration() const'
lib/ProfileData/CMakeFiles/LLVMProfileData.dir/InstrProf.cpp.o: In function `llvm::canRenameComdatFunc(llvm::Function const&, bool)':
InstrProf.cpp:(.text._ZN4llvm19canRenameComdatFuncERKNS_8FunctionEb+0x24): undefined reference to `llvm::Value::getName() const'
InstrProf.cpp:(.text._ZN4llvm19canRenameComdatFuncERKNS_8FunctionEb+0x14c): undefined reference to `llvm::Function::hasAddressTaken(llvm::User const**, bool, bool, bool, bool, bool) const'
lib/ProfileData/CMakeFiles/LLVMProfileData.dir/InstrProf.cpp.o: In function `llvm::createProfileFileNameVar(llvm::Module&, llvm::StringRef)':
InstrProf.cpp:(.text._ZN4llvm24createProfileFileNameVarERNS_6ModuleENS_9StringRefE+0x3c): undefined reference to `llvm::ConstantDataArray::getString(llvm::LLVMContext&, llvm::StringRef, bool)'

```

</details>

https://github.com/llvm/llvm-project/pull/140505