[llvm] [GlobalISel] Make scalar G_SHUFFLE_VECTOR illegal. (PR #140508)
via llvm-commits
llvm-commits at lists.llvm.org
Mon May 19 00:24:42 PDT 2025
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff HEAD~1 HEAD --extensions h,cpp -- llvm/include/llvm/CodeGen/GlobalISel/CombinerHelper.h llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp llvm/lib/CodeGen/GlobalISel/GISelValueTracking.cpp llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp llvm/lib/CodeGen/GlobalISel/MachineIRBuilder.cpp llvm/lib/CodeGen/MachineVerifier.cpp llvm/lib/Target/AArch64/GISel/AArch64InstructionSelector.cpp llvm/lib/Target/AArch64/GISel/AArch64LegalizerInfo.cpp
``````````
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp b/llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp
index fceca2074..6078288c1 100644
--- a/llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp
+++ b/llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp
@@ -3346,12 +3346,10 @@ bool IRTranslator::translateShuffleVector(const User &U,
if (M < SrcElts) {
MIRBuilder.buildExtractVectorElementConstant(
getOrCreateVReg(U), getOrCreateVReg(*U.getOperand(0)), M);
- }
- else if (M < SrcElts * 2) {
+ } else if (M < SrcElts * 2) {
MIRBuilder.buildExtractVectorElementConstant(
getOrCreateVReg(U), getOrCreateVReg(*U.getOperand(1)), M - SrcElts);
- }
- else {
+ } else {
MIRBuilder.buildUndef(getOrCreateVReg(U));
}
return true;
diff --git a/llvm/lib/Target/AArch64/GISel/AArch64LegalizerInfo.cpp b/llvm/lib/Target/AArch64/GISel/AArch64LegalizerInfo.cpp
index fe5022b71..9262f0c84 100644
--- a/llvm/lib/Target/AArch64/GISel/AArch64LegalizerInfo.cpp
+++ b/llvm/lib/Target/AArch64/GISel/AArch64LegalizerInfo.cpp
@@ -1178,14 +1178,14 @@ AArch64LegalizerInfo::AArch64LegalizerInfo(const AArch64Subtarget &ST)
.moreElementsIf(
[](const LegalityQuery &Query) {
return Query.Types[0].getNumElements() >
- Query.Types[1].getNumElements();
+ Query.Types[1].getNumElements();
},
changeTo(1, 0))
.moreElementsToNextPow2(0)
.moreElementsIf(
[](const LegalityQuery &Query) {
return Query.Types[0].getNumElements() <
- Query.Types[1].getNumElements();
+ Query.Types[1].getNumElements();
},
changeTo(0, 1))
.widenScalarOrEltToNextPow2OrMinSize(0, 8)
``````````
</details>
https://github.com/llvm/llvm-project/pull/140508
More information about the llvm-commits
mailing list