[llvm] [llvm-debuginfo-analyzer] Use `LLVM_BUILD_DEBUG` in class definitions (PR #140265)

[David Blaikie via llvm-commits]

dwblaikie wrote:

> > I think we already have a separate macro for this - ABI_BREAKING_CHECKS, perhaps?
> 
> Hmmm... unsure; according to [llvm/docs/ProgrammersManual.rst](https://github.com/llvm/llvm-project/blob/main/llvm/docs/ProgrammersManual.rst), this PP macro serves a slightly different purpose, but we could probably also use it here. WDYT, @CarlosAlbertoEnciso?

The difference being a debug build V an asserts-ish build? Yeah, I think the right thing to do would be to make these members enabled/disabled based on ABI_BREAKING_CHECKS.. 
Oh, the issue is these aren't checks? They're only for debug dumping features? That is a bit awkward. Do they have to be ABI breaking to provide debugging features/could they be implemented in some other way? (& I don't think we enable dump functions based on whether it's a debug build, right? There's some separate macro for that?)

Might be worth a discourse post for discussion

https://github.com/llvm/llvm-project/pull/140265