[llvm] ec7a509 - ELFObjectWriter: Simplify R_PPC64_TOC special case. NFC

Fangrui Song via llvm-commits llvm-commits at lists.llvm.org
Sun May 18 14:57:00 PDT 2025


Author: Fangrui Song
Date: 2025-05-18T14:56:55-07:00
New Revision: ec7a5091655f75839e8da57a76aec6600a864915

URL: https://github.com/llvm/llvm-project/commit/ec7a5091655f75839e8da57a76aec6600a864915
DIFF: https://github.com/llvm/llvm-project/commit/ec7a5091655f75839e8da57a76aec6600a864915.diff

LOG: ELFObjectWriter: Simplify R_PPC64_TOC special case. NFC

Added: 
    

Modified: 
    llvm/lib/MC/ELFObjectWriter.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/MC/ELFObjectWriter.cpp b/llvm/lib/MC/ELFObjectWriter.cpp
index 55a6bab003b31..4c68fb54dcd2d 100644
--- a/llvm/lib/MC/ELFObjectWriter.cpp
+++ b/llvm/lib/MC/ELFObjectWriter.cpp
@@ -1378,7 +1378,6 @@ void ELFObjectWriter::recordRelocation(MCAssembler &Asm,
     Addend += FixupOffset - Asm.getSymbolOffset(SymB);
   }
 
-  auto EMachine = TargetObjectWriter->getEMachine();
   unsigned Type;
   if (mc::isRelocRelocation(Fixup.getKind()))
     Type = Fixup.getKind() - FirstLiteralRelocationKind;
@@ -1404,7 +1403,8 @@ void ELFObjectWriter::recordRelocation(MCAssembler &Asm,
   } else {
     // In PPC64 ELFv1, .quad .TOC. at tocbase in the .opd section is expected to
     // reference the null symbol.
-    if (Type == ELF::R_PPC64_TOC && EMachine == ELF::EM_PPC64)
+    if (Type == ELF::R_PPC64_TOC &&
+        TargetObjectWriter->getEMachine() == ELF::EM_PPC64)
       SymA = nullptr;
 
     if (SymA) {


        


More information about the llvm-commits mailing list