[lld] [lld] Support order cstrings with -order_file_cstring (PR #140307)

via llvm-commits llvm-commits at lists.llvm.org
Fri May 16 16:18:30 PDT 2025


================
@@ -337,15 +337,15 @@ static InputFile *addFile(StringRef path, LoadType loadType,
         for (const object::Archive::Child &c : file->getArchive().children(e)) {
           StringRef reason;
           switch (loadType) {
-            case LoadType::LCLinkerOption:
-              reason = "LC_LINKER_OPTION";
-              break;
-            case LoadType::CommandLineForce:
-              reason = "-force_load";
-              break;
-            case LoadType::CommandLine:
-              reason = "-all_load";
-              break;
+          case LoadType::LCLinkerOption:
+            reason = "LC_LINKER_OPTION";
+            break;
+          case LoadType::CommandLineForce:
+            reason = "-force_load";
+            break;
+          case LoadType::CommandLine:
+            reason = "-all_load";
+            break;
----------------
SharonXSharon wrote:

I noticed these too, but then I looked other switch/case code in the file/repo, the removed whitespace is actually legit w.r.t. clang format, i.e. other  switch/case doesn't have that extra space, so maybe it's okay to check in the correction of those format? 

https://github.com/llvm/llvm-project/pull/140307


More information about the llvm-commits mailing list