[llvm] [StaticDataLayout][PGO]Implement reader and writer change for data access profiles (PR #139997)
Mingming Liu via llvm-commits
llvm-commits at lists.llvm.org
Fri May 16 12:29:00 PDT 2025
================
@@ -225,6 +228,8 @@ static Error writeMemProfRadixTreeBased(
OS.write(0ULL); // Reserve space for the memprof call stack payload offset.
OS.write(0ULL); // Reserve space for the memprof record payload offset.
OS.write(0ULL); // Reserve space for the memprof record table offset.
+ if (Version == memprof::Version4)
----------------
mingmingl-llvm wrote:
Updated check to be `>=` here and around L 277.
> does the version need to be bumped for this change?
Yeah, that's a good question. https://github.com/llvm/llvm-project/commit/099a0fa3f2cf1a434e20b2fa97b6251088321467 (by @snehasish) introduces v4 which contains `CalleeGuids` in `CallSiteInfo`, and this change changes the v4 format in place with data access profiles.
Snehasish and I have been discussing to bump the version once and enable v4 profiles with both features, assuming waiting for this change won't delay the callsite change too long. I updated the PR description to call this out.
https://github.com/llvm/llvm-project/pull/139997
More information about the llvm-commits
mailing list