[llvm] Reapply: [llvm-objdump] Add support for HIP offload bundles (PR #140128)

Kazu Hirata via llvm-commits llvm-commits at lists.llvm.org
Fri May 16 07:27:48 PDT 2025


kazutakahirata wrote:

@david-salinas I've reverted the PR.  I'm happy to to try your revised PR, so please feel free to add me to the reviewer list.  Thanks!

I'm not sure if the following warnings are caught by the build bot, but I am getting:

```
llvm/include/llvm/Object/OffloadBundle.h:148:5: error: default label in switch which covers all enumeration values [-Werror,-Wcovered-switch-default]
  148 |     default:
      |     ^
llvm/include/llvm/Object/OffloadBundle.h:118:5: error: non-void lambda does not return a value in all control paths [-Werror,-Wreturn-type]
  118 |     });
      |     ^
```

While we are at it, maybe you can drop the initializer?

```
    SmallVector<OffloadBundleEntry> Found = SmallVector<OffloadBundleEntry>();
```

Just like `std::vector`, `SmallVector` starts out being empty.


https://github.com/llvm/llvm-project/pull/140128


More information about the llvm-commits mailing list