[llvm] [DirectX] Scalarize Allocas as part of data scalarization (PR #140165)

Deric C. via llvm-commits llvm-commits at lists.llvm.org
Thu May 15 17:54:58 PDT 2025


================
@@ -40,9 +41,10 @@ static bool findAndReplaceVectors(Module &M);
 class DataScalarizerVisitor : public InstVisitor<DataScalarizerVisitor, bool> {
 public:
   DataScalarizerVisitor() : GlobalMap() {}
-  bool visit(Instruction &I);
+  bool visit(Function &F);
----------------
Icohedron wrote:

nit: It seems rather odd to make the `visit` accept a Function arg instead of an Instruction, while the other `visit*` functions still take a (subclass of) Instruction. It doesn't really fit the usual visitor pattern.

https://github.com/llvm/llvm-project/pull/140165


More information about the llvm-commits mailing list