[llvm] [llvm-exegesis] Error instead of aborting on verification failure (PR #137581)
Aiden Grossman via llvm-commits
llvm-commits at lists.llvm.org
Thu May 15 15:44:38 PDT 2025
================
@@ -323,10 +324,8 @@ Error assembleToStream(const ExegesisTarget &ET,
TPC->printAndVerify("After ExegesisTarget::addTargetSpecificPasses");
----------------
boomanaiden154 wrote:
Those only run when passing `-verify-machineinstrs` on the command line. It's a lot harder to return an error there rather than just abort given the calls are to the MachineVerifier are nested within the pass pipeline, and the checks need to be explicitly enabled by the user on the command line where I think aborting is probably the most reasonable course of action.
https://github.com/llvm/llvm-project/pull/137581
More information about the llvm-commits
mailing list