[llvm] Reapply: [llvm-objdump] Add support for HIP offload bundles (PR #140128)

via llvm-commits llvm-commits at lists.llvm.org
Thu May 15 12:43:16 PDT 2025


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff HEAD~1 HEAD --extensions h,cpp -- llvm/include/llvm/Object/OffloadBundle.h llvm/lib/Object/OffloadBundle.cpp llvm/unittests/Object/OffloadingBundleTest.cpp llvm/tools/llvm-objdump/OffloadDump.cpp llvm/tools/llvm-objdump/OffloadDump.h llvm/tools/llvm-objdump/llvm-objdump.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/lib/Object/OffloadBundle.cpp b/llvm/lib/Object/OffloadBundle.cpp
index 2ecd669f8..5f087a5c8 100644
--- a/llvm/lib/Object/OffloadBundle.cpp
+++ b/llvm/lib/Object/OffloadBundle.cpp
@@ -172,8 +172,9 @@ Error object::extractOffloadBundleFatBinary(
       uint64_t SectionOffset = 0;
       if (Obj.isELF()) {
         SectionOffset = ELFSectionRef(Sec).getOffset();
-      } else if (Obj.isCOFF()) // TODO: add COFF Support 
-        return createStringError(object_error::parse_failed, "COFF object files not supported.\n");
+      } else if (Obj.isCOFF()) // TODO: add COFF Support
+        return createStringError(object_error::parse_failed,
+                                 "COFF object files not supported.\n");
 
       MemoryBufferRef Contents(*Buffer, Obj.getFileName());
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/140128


More information about the llvm-commits mailing list