[llvm] 6033a48 - [CodeGen] Use std::tie to implement a comparison functor (NFC) (#140088)

via llvm-commits llvm-commits at lists.llvm.org
Thu May 15 12:18:57 PDT 2025


Author: Kazu Hirata
Date: 2025-05-15T12:18:54-07:00
New Revision: 6033a4859a0131062bef4eb765b438e6110b40a2

URL: https://github.com/llvm/llvm-project/commit/6033a4859a0131062bef4eb765b438e6110b40a2
DIFF: https://github.com/llvm/llvm-project/commit/6033a4859a0131062bef4eb765b438e6110b40a2.diff

LOG: [CodeGen] Use std::tie to implement a comparison functor (NFC) (#140088)

std::tie simplifies the lexicographical comparison while making the
code a little more consistent within MIRPrinter.cpp as we have a very
similar comparison functor in MIRPrinter::convertCalledGlobals, about
30 lines below the code this patch touches.

Added: 
    

Modified: 
    llvm/lib/CodeGen/MIRPrinter.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/CodeGen/MIRPrinter.cpp b/llvm/lib/CodeGen/MIRPrinter.cpp
index 906048679553c..d8dc00f7a61f7 100644
--- a/llvm/lib/CodeGen/MIRPrinter.cpp
+++ b/llvm/lib/CodeGen/MIRPrinter.cpp
@@ -575,9 +575,8 @@ void MIRPrinter::convertCallSiteObjects(yaml::MachineFunction &YMF,
   // Sort call info by position of call instructions.
   llvm::sort(YMF.CallSitesInfo.begin(), YMF.CallSitesInfo.end(),
              [](yaml::CallSiteInfo A, yaml::CallSiteInfo B) {
-               if (A.CallLocation.BlockNum == B.CallLocation.BlockNum)
-                 return A.CallLocation.Offset < B.CallLocation.Offset;
-               return A.CallLocation.BlockNum < B.CallLocation.BlockNum;
+               return std::tie(A.CallLocation.BlockNum, A.CallLocation.Offset) <
+                      std::tie(B.CallLocation.BlockNum, B.CallLocation.Offset);
              });
 }
 


        


More information about the llvm-commits mailing list