[llvm] 059b0c2 - [ValueTracking][NFC] Drop outdated TODO in canCreateUndefOrPoison (#139915)

via llvm-commits llvm-commits at lists.llvm.org
Thu May 15 07:09:19 PDT 2025


Author: Cullen Rhodes
Date: 2025-05-15T15:09:15+01:00
New Revision: 059b0c2efbf30d986d812c4d2cf6d6c7876569fe

URL: https://github.com/llvm/llvm-project/commit/059b0c2efbf30d986d812c4d2cf6d6c7876569fe
DIFF: https://github.com/llvm/llvm-project/commit/059b0c2efbf30d986d812c4d2cf6d6c7876569fe.diff

LOG: [ValueTracking][NFC] Drop outdated TODO in canCreateUndefOrPoison (#139915)

The inrange constexpr GEP case is handled since 425cbbc602c9.

Added: 
    

Modified: 
    llvm/lib/Analysis/ValueTracking.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Analysis/ValueTracking.cpp b/llvm/lib/Analysis/ValueTracking.cpp
index 3d403531cea2f..8405678aa9680 100644
--- a/llvm/lib/Analysis/ValueTracking.cpp
+++ b/llvm/lib/Analysis/ValueTracking.cpp
@@ -7786,10 +7786,7 @@ static bool canCreateUndefOrPoison(const Operator *Op, UndefPoisonKind Kind,
   case Instruction::FMul:
   case Instruction::FDiv:
   case Instruction::FRem:
-    return false;
   case Instruction::GetElementPtr:
-    // inbounds is handled above
-    // TODO: what about inrange on constexpr?
     return false;
   default: {
     const auto *CE = dyn_cast<ConstantExpr>(Op);


        


More information about the llvm-commits mailing list