[llvm] update_mir_test_checks: keep commment embedded in MIR (PR #140016)

via llvm-commits llvm-commits at lists.llvm.org
Thu May 15 00:22:56 PDT 2025


https://github.com/ruiling created https://github.com/llvm/llvm-project/pull/140016

We often add inline comment in mir. It is useful to keep them.

>From 75947e2d6c2937bf2b4e6ca28f3de9235068d032 Mon Sep 17 00:00:00 2001
From: Ruiling Song <ruiling.song at amd.com>
Date: Mon, 12 May 2025 10:37:48 +0800
Subject: [PATCH] update_mir_test_checks: keep commment embedded in MIR

We often add inline comment in mir. It is useful to keep them.
---
 llvm/utils/update_mir_test_checks.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/llvm/utils/update_mir_test_checks.py b/llvm/utils/update_mir_test_checks.py
index 86147034d946b..8deaec74f2777 100755
--- a/llvm/utils/update_mir_test_checks.py
+++ b/llvm/utils/update_mir_test_checks.py
@@ -339,9 +339,9 @@ def mangle_vreg(opcode, current_names):
 
 
 def should_add_line_to_output(input_line, prefix_set):
-    # Skip any check lines that we're handling as well as comments
+    # Skip any check lines that we're handling as well as blank comment.
     m = common.CHECK_RE.match(input_line)
-    if (m and m.group(1) in prefix_set) or re.search("^[ \t]*;", input_line):
+    if (m and m.group(1) in prefix_set) or input_line.strip() == ";":
         return False
     return True
 



More information about the llvm-commits mailing list