[llvm] Revert "[SimplifyCFG] Deduce paths unreachable if they cause div/rem UB" (PR #137741)
Bill Wendling via llvm-commits
llvm-commits at lists.llvm.org
Wed May 14 10:24:24 PDT 2025
bwendling wrote:
> Hey @bwendling, just a friendly reminder that the community has a [Code of Conduct](https://llvm.org/docs/CodeOfConduct.html). Dismissing someone's review as not being "serious" is a pretty negative experience, and code review bandwidth is something our community perpetually struggles with. It's better to address the technical points in the review on their own merits than to simply dismiss the entire review (barring extenuating circumstances like a bad faith review, but that does not seem to be the case here). For next time, I think this could have been handled by simply waiting for (or asking for) additional eyeballs on the review to increase confidence in the correctness of the patch. For this time, maybe edit your comment and/or add a small apology?
@dtcxzyw I apologize for the comment I made. The reviews were shrugging off the bad code generation and it made me angry and I inappropriately took that out on you.
https://github.com/llvm/llvm-project/pull/137741
More information about the llvm-commits
mailing list