[llvm] [LLVM][TableGen] Code cleanup in FastISelEmitter.cpp (PR #139644)
Rahul Joshi via llvm-commits
llvm-commits at lists.llvm.org
Wed May 14 09:57:24 PDT 2025
================
@@ -304,77 +295,74 @@ struct OperandsSignature {
void PrintParameters(raw_ostream &OS) const {
ListSeparator LS;
- for (unsigned i = 0, e = Operands.size(); i != e; ++i) {
+ for (const auto [Idx, Opnd] : enumerate(Operands)) {
OS << LS;
- if (Operands[i].isReg()) {
- OS << "Register Op" << i;
- } else if (Operands[i].isImm()) {
- OS << "uint64_t imm" << i;
- } else if (Operands[i].isFP()) {
- OS << "const ConstantFP *f" << i;
- } else {
+ if (Opnd.isReg())
+ OS << "Register Op" << Idx;
+ else if (Opnd.isImm())
+ OS << "uint64_t imm" << Idx;
+ else if (Opnd.isFP())
+ OS << "const ConstantFP *f" << Idx;
+ else
llvm_unreachable("Unknown operand kind!");
- }
}
}
- void PrintArguments(raw_ostream &OS,
- const std::vector<std::string> &PR) const {
- assert(PR.size() == Operands.size());
+ void PrintArguments(raw_ostream &OS, ArrayRef<std::string> PhyRegs) const {
ListSeparator LS;
- for (unsigned i = 0, e = Operands.size(); i != e; ++i) {
- if (PR[i] != "")
+ for (const auto [Idx, Opnd, PhyReg] : enumerate(Operands, PhyRegs)) {
+ if (PhyReg != "") {
----------------
jurahul wrote:
Done
https://github.com/llvm/llvm-project/pull/139644
More information about the llvm-commits
mailing list