[llvm] [LLVM][TableGen] Code cleanup in FastISelEmitter.cpp (PR #139644)

Rahul Joshi via llvm-commits llvm-commits at lists.llvm.org
Wed May 14 09:35:09 PDT 2025


jurahul wrote:

> Please do _never_ amend commits after reviewers left comments. This makes it much more difficult to do incremental review, or (when combined with rebase) practically impossible. Constant rebases aren't needed either. If you really need to update the branch (to resolve merge conflicts is the only valid reason), press the "Updata branch" button in GitHub UI.

Agreed. I don't think I did it for this PR, unless I am missing something. But I might have done for some earlier PRs as a part of addressing review comments. In that case I do tend to rebase on top of latest changes and then apply the additional delta to address review comments, and I can see how that can impede incremental reviews. I'll be more mindful going forward and refrain from doing that.

https://github.com/llvm/llvm-project/pull/139644


More information about the llvm-commits mailing list