[llvm] [llvm-profdata] Disable -all-functions by default (PR #138105)
Nabeel Omer via llvm-commits
llvm-commits at lists.llvm.org
Wed May 14 09:24:58 PDT 2025
omern1 wrote:
Hi, thanks for looking at this.
> ... and I think line 3018 should probably be changed similarly?
I'll do so shortly.
> That being said, if the default has always been to show all functions, it might make sense to make this code change but also flip the -all-functions default to true to maintain the status quo (but then the code change here fixes the issue where -all-functions=false would do nothing without -function= ).
I think that would somewhat defeat the purpose of this patch (improving the interactive user experience) but I do see the argument for maintaining existing behaviour. I have a weak preference for not doing so though.
https://github.com/llvm/llvm-project/pull/138105
More information about the llvm-commits
mailing list