[llvm] [llvm] properly guard dump methods in Support lib classes (PR #139804)

[Andrew Rogers via llvm-commits]

andrurogerz wrote:

this change is breaking several build jobs:
```
FAILED: tools/clang/lib/StaticAnalyzer/Core/CMakeFiles/obj.clangStaticAnalyzerCore.dir/SMTConstraintManager.cpp.o 
CCACHE_CPP2=yes CCACHE_HASHDIR=yes CCACHE_SLOPPINESS=pch_defines,time_macros /usr/bin/ccache /usr/bin/clang++ -DCLANG_EXPORTS -DGTEST_HAS_RTTI=0 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/b/sanitizer-aarch64-linux-fuzzer/build/llvm_build0/tools/clang/lib/StaticAnalyzer/Core -I/home/b/sanitizer-aarch64-linux-fuzzer/build/llvm-project/clang/lib/StaticAnalyzer/Core -I/home/b/sanitizer-aarch64-linux-fuzzer/build/llvm-project/clang/include -I/home/b/sanitizer-aarch64-linux-fuzzer/build/llvm_build0/tools/clang/include -I/home/b/sanitizer-aarch64-linux-fuzzer/build/llvm_build0/include -I/home/b/sanitizer-aarch64-linux-fuzzer/build/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -Wno-nested-anon-types -O3 -DNDEBUG -std=c++17  -fno-exceptions -funwind-tables -fno-rtti -MD -MT tools/clang/lib/StaticAnalyzer/Core/CMakeFiles/obj.clangStaticAnalyzerCore.dir/SMTConstraintManager.cpp.o -MF tools/clang/lib/StaticAnalyzer/Core/CMakeFiles/obj.clangStaticAnalyzerCore.dir/SMTConstraintManager.cpp.o.d -o tools/clang/lib/StaticAnalyzer/Core/CMakeFiles/obj.clangStaticAnalyzerCore.dir/SMTConstraintManager.cpp.o -c /home/b/sanitizer-aarch64-linux-fuzzer/build/llvm-project/clang/lib/StaticAnalyzer/Core/SMTConstraintManager.cpp
In file included from /home/b/sanitizer-aarch64-linux-fuzzer/build/llvm-project/clang/lib/StaticAnalyzer/Core/SMTConstraintManager.cpp:9:
/home/b/sanitizer-aarch64-linux-fuzzer/build/llvm-project/clang/include/clang/StaticAnalyzer/Core/PathSensitive/SMTConstraintManager.h:305:48: error: no member named 'dump' in 'llvm::SMTSolver'
  305 |   LLVM_DUMP_METHOD void dump() const { Solver->dump(); }
      |                                        ~~~~~~~~^
1 error generated.
```

https://github.com/llvm/llvm-project/pull/139804