[llvm] AMDGPU: Add sgpr bit convert tests (PR #136112)
via llvm-commits
llvm-commits at lists.llvm.org
Wed May 14 06:26:28 PDT 2025
Shoreshen wrote:
> > > > Hi @mikaelholmen , the fix up PR has been merges, please check. Sorry again and thank you for notifying me!
> > >
> > >
> > > Great!
> > > I'm a little surprised that there are no comments here in this patch from failing expensive-checks build bots due to this. Now I saw the failure in downstream non-public bots instead.
> >
> >
> > Hi @mikaelholmen thanks, I'm surprised too... BTW can you double check if the case has been resolved? Since I see the latest commits are still failing expensive check........
> > But it looks like the cases are not from this PR...
>
> The amdgcn.bitcast.1024bit.ll testcases passes for me even with EXPENSIVE_CHECKS after your fix.
>
> (Btw, that testcase is pretty bonkers... 250374 lines and takes a long time to execute.)
Bit of history....
First in here: https://github.com/llvm/llvm-project/pull/131775#discussion_r2001101365
Then following the comments I put up this PR:https://github.com/llvm/llvm-project/pull/131955
I'll discuss with the team and see if we can change it back to only check the function name....
https://github.com/llvm/llvm-project/pull/136112
More information about the llvm-commits
mailing list