[llvm] 019d769 - [MIPS]Fix QNaNs in the MIPS legacy NaN encodings (#139829)

[via llvm-commits]

Author: anbbna
Date: 2025-05-14T05:25:47-04:00
New Revision: 019d7694df91d75322e3c19ebc2e1aa7d3120e02

URL: https://github.com/llvm/llvm-project/commit/019d7694df91d75322e3c19ebc2e1aa7d3120e02
DIFF: https://github.com/llvm/llvm-project/commit/019d7694df91d75322e3c19ebc2e1aa7d3120e02.diff

LOG: [MIPS]Fix QNaNs in the MIPS legacy NaN encodings (#139829)

The MSB of the mantissa should be zero for QNaNs in the MIPS legacy NaN
encodings, and one for sNaNs.

Fix #100495

Added: 
    llvm/test/CodeGen/Mips/qnan.ll

Modified: 
    llvm/lib/Target/Mips/MipsISelLowering.cpp
    llvm/lib/Target/Mips/MipsISelLowering.h

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/Mips/MipsISelLowering.cpp b/llvm/lib/Target/Mips/MipsISelLowering.cpp
index 66cbf79a453a6..e933e97ea3706 100644
--- a/llvm/lib/Target/Mips/MipsISelLowering.cpp
+++ b/llvm/lib/Target/Mips/MipsISelLowering.cpp
@@ -520,6 +520,9 @@ MipsTargetLowering::MipsTargetLowering(const MipsTargetMachine &TM,
 
   setOperationAction(ISD::TRAP, MVT::Other, Legal);
 
+  setOperationAction(ISD::ConstantFP, MVT::f32, Custom);
+  setOperationAction(ISD::ConstantFP, MVT::f64, Custom);
+
   setTargetDAGCombine({ISD::SDIVREM, ISD::UDIVREM, ISD::SELECT, ISD::AND,
                        ISD::OR, ISD::ADD, ISD::SUB, ISD::AssertZext, ISD::SHL,
                        ISD::SIGN_EXTEND});
@@ -1355,6 +1358,8 @@ LowerOperation(SDValue Op, SelectionDAG &DAG) const
   case ISD::FP_TO_SINT:         return lowerFP_TO_SINT(Op, DAG);
   case ISD::READCYCLECOUNTER:
     return lowerREADCYCLECOUNTER(Op, DAG);
+  case ISD::ConstantFP:
+    return lowerConstantFP(Op, DAG);
   }
   return SDValue();
 }
@@ -3015,6 +3020,30 @@ SDValue MipsTargetLowering::lowerFP_TO_SINT(SDValue Op,
   return DAG.getNode(ISD::BITCAST, SDLoc(Op), Op.getValueType(), Trunc);
 }
 
+SDValue MipsTargetLowering::lowerConstantFP(SDValue Op,
+                                            SelectionDAG &DAG) const {
+  SDLoc DL(Op);
+  EVT VT = Op.getSimpleValueType();
+  SDNode *N = Op.getNode();
+  ConstantFPSDNode *CFP = cast<ConstantFPSDNode>(N);
+
+  if (!CFP->isNaN() || Subtarget.isNaN2008()) {
+    return SDValue();
+  }
+
+  APFloat NaNValue = CFP->getValueAPF();
+  auto &Sem = NaNValue.getSemantics();
+
+  // The MSB of the mantissa should be zero for QNaNs in the MIPS legacy NaN
+  // encodings, and one for sNaNs. Check every NaN constants and make sure
+  // they are correctly encoded for legacy encodings.
+  if (!NaNValue.isSignaling()) {
+    APFloat RealQNaN = NaNValue.getSNaN(Sem);
+    return DAG.getConstantFP(RealQNaN, DL, VT);
+  }
+  return SDValue();
+}
+
 //===----------------------------------------------------------------------===//
 //                      Calling Convention Implementation
 //===----------------------------------------------------------------------===//

diff  --git a/llvm/lib/Target/Mips/MipsISelLowering.h b/llvm/lib/Target/Mips/MipsISelLowering.h
index 9885ab894d6f2..241e9343ae384 100644
--- a/llvm/lib/Target/Mips/MipsISelLowering.h
+++ b/llvm/lib/Target/Mips/MipsISelLowering.h
@@ -592,6 +592,7 @@ class TargetRegisterClass;
     SDValue lowerEH_DWARF_CFA(SDValue Op, SelectionDAG &DAG) const;
     SDValue lowerFP_TO_SINT(SDValue Op, SelectionDAG &DAG) const;
     SDValue lowerREADCYCLECOUNTER(SDValue Op, SelectionDAG &DAG) const;
+    SDValue lowerConstantFP(SDValue Op, SelectionDAG &DAG) const;
 
     /// isEligibleForTailCallOptimization - Check whether the call is eligible
     /// for tail call optimization.

diff  --git a/llvm/test/CodeGen/Mips/qnan.ll b/llvm/test/CodeGen/Mips/qnan.ll
new file mode 100644
index 0000000000000..e5b4aa1b42ee7
--- /dev/null
+++ b/llvm/test/CodeGen/Mips/qnan.ll
@@ -0,0 +1,14 @@
+; RUN: llc -O3 -mcpu=mips32r2 -mtriple=mips-linux-gnu < %s -o - | FileCheck %s -check-prefixes=MIPS_Legacy
+; RUN: llc -O3 -mcpu=mips32r2 -mtriple=mips-linux-gnu -mattr=+nan2008 < %s -o - | FileCheck %s -check-prefixes=MIPS_NaN2008
+
+define dso_local float @nan(float noundef %a, float noundef %b) local_unnamed_addr #0 {
+; MIPS_Legacy: $CPI0_0:
+; MIPS_Legacy-NEXT: .4byte  0x7fa00000 # float NaN
+
+; MIPS_NaN2008: $CPI0_0:
+; MIPS_NaN2008-NEXT: .4byte  0x7fc00000 # float NaN
+
+entry:
+  %0 = tail call float @llvm.minimum.f32(float %a, float %b)
+  ret float %0
+}