[llvm] [TableGen] Avoid assignmentInAssert warning (PR #139715)

Tue May 13 05:13:06 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `amdgpu-offload-rhel-8-cmake-build-only` running on `rocm-docker-rhel-8` while building `llvm` at step 4 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/204/builds/9208

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 4 (annotate) failure: '../llvm-zorg/zorg/buildbot/builders/annotated/amdgpu-offload-cmake.py --jobs=32' (failure)
...
[5010/7809] Building R600GenMCCodeEmitter.inc...
[5011/7809] Building R600GenSubtargetInfo.inc...
[5012/7809] Building SPIRVGenAsmWriter.inc...
[5013/7809] Building SPIRVGenGlobalISel.inc...
[5014/7809] Building SPIRVGenInstrInfo.inc...
[5015/7809] Building SPIRVGenRegisterInfo.inc...
[5016/7809] Building SPIRVGenSubtargetInfo.inc...
[5017/7809] Building SPIRVGenRegisterBank.inc...
[5018/7809] Building SPIRVGenMCCodeEmitter.inc...
[5019/7809] Building SPIRVGenPreLegalizeGICombiner.inc...
FAILED: lib/Target/SPIRV/SPIRVGenPreLegalizeGICombiner.inc /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/lib/Target/SPIRV/SPIRVGenPreLegalizeGICombiner.inc 
cd /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/lib/Target/SPIRV && /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/bin/llvm-tblgen -gen-global-isel-combiner -combiners="SPIRVPreLegalizerCombiner" -I /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/lib/Target/SPIRV -I/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/include -I/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/include -I /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/lib/Target /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/lib/Target/SPIRV/SPIRV.td --write-if-changed -o SPIRVGenPreLegalizeGICombiner.inc -d SPIRVGenPreLegalizeGICombiner.inc.d && /usr/bin/cmake -E cmake_transform_depfile Ninja gccdepfile /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/lib/Target/SPIRV /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/lib/Target/SPIRV /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/lib/Target/SPIRV/SPIRVGenPreLegalizeGICombiner.inc.d /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/CMakeFiles/d/7cd2fd85e424a7f3874819f478986a2e4f343a9e41f30908c1f456e5e69bde96.d
llvm-tblgen: /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/utils/TableGen/GlobalISelCombinerEmitter.cpp:2615: virtual void {anonymous}::GICombinerEmitter::emitTestSimplePredicate(llvm::raw_ostream&): Assertion `ExpectedID == ID && "combine rules are not ordered!"' failed.
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace.
Stack dump:
0.	Program arguments: /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/bin/llvm-tblgen -gen-global-isel-combiner -combiners=SPIRVPreLegalizerCombiner -I /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/lib/Target/SPIRV -I/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/include -I/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/include -I /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/lib/Target /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/lib/Target/SPIRV/SPIRV.td --write-if-changed -o SPIRVGenPreLegalizeGICombiner.inc -d SPIRVGenPreLegalizeGICombiner.inc.d
 #0 0x00007a9191be5318 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/bin/../lib/libLLVMSupport.so.21.0git+0x1e5318)
 #1 0x00007a9191be29ec SignalHandler(int, siginfo_t*, void*) Signals.cpp:0:0
 #2 0x00007a9191ff2990 __restore_rt (/lib64/libpthread.so.0+0x12990)
 #3 0x00007a9190d4952f raise (/lib64/libc.so.6+0x4e52f)
 #4 0x00007a9190d1ce65 abort (/lib64/libc.so.6+0x21e65)
 #5 0x00007a9190d1cd39 _nl_load_domain.cold.0 (/lib64/libc.so.6+0x21d39)
 #6 0x00007a9190d41e86 (/lib64/libc.so.6+0x46e86)
 #7 0x00000000005e82b8 (/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/bin/llvm-tblgen+0x5e82b8)
 #8 0x000000000046f732 llvm::GlobalISelMatchTableExecutorEmitter::emitExecutorImpl(llvm::raw_ostream&, llvm::gi::MatchTable const&, llvm::ArrayRef<llvm::gi::LLTCodeGen>, llvm::ArrayRef<llvm::gi::RuleMatcher>, llvm::ArrayRef<llvm::Record const*>, llvm::ArrayRef<llvm::StringRef>, llvm::StringRef) (/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/bin/llvm-tblgen+0x46f732)
 #9 0x00000000005fe1af EmitGICombiner(llvm::RecordKeeper const&, llvm::raw_ostream&) GlobalISelCombinerEmitter.cpp:0:0
#10 0x00007a919225126a llvm::TableGen::Emitter::ApplyCallback(llvm::RecordKeeper const&, llvm::raw_ostream&) (/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/bin/../lib/libLLVMTableGen.so.21.0git+0x5126a)
#11 0x00007a9192222690 llvm::TableGenMain(char const*, std::function<bool (llvm::raw_ostream&, llvm::RecordKeeper const&)>) (/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/bin/../lib/libLLVMTableGen.so.21.0git+0x22690)
#12 0x000000000043fd1e tblgen_main(int, char**) (/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/bin/llvm-tblgen+0x43fd1e)
#13 0x00007a9190d357e5 __libc_start_main (/lib64/libc.so.6+0x3a7e5)
#14 0x000000000040e77e _start (/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/bin/llvm-tblgen+0x40e77e)
/bin/sh: line 1: 3680553 Aborted                 (core dumped) /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/bin/llvm-tblgen -gen-global-isel-combiner -combiners="SPIRVPreLegalizerCombiner" -I /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/lib/Target/SPIRV -I/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/include -I/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/include -I /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/lib/Target /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/lib/Target/SPIRV/SPIRV.td --write-if-changed -o SPIRVGenPreLegalizeGICombiner.inc -d SPIRVGenPreLegalizeGICombiner.inc.d
[5020/7809] Building SPIRVGenTables.inc...
[5021/7809] Building X86GenCallingConv.inc...
[5022/7809] Building X86GenAsmWriter1.inc...
[5023/7809] Building X86GenAsmWriter.inc...
[5024/7809] Building X86GenAsmMatcher.inc...
[5025/7809] Building X86GenDisassemblerTables.inc...
[5026/7809] Building CXX object tools/flang/lib/Support/CMakeFiles/FortranSupport.dir/OpenMP-utils.cpp.o
[5027/7809] Building CXX object lib/CodeGen/AsmPrinter/CMakeFiles/LLVMAsmPrinter.dir/AsmPrinter.cpp.o
[5028/7809] Building CXX object lib/LTO/CMakeFiles/LLVMLTO.dir/LTO.cpp.o
In file included from /usr/include/c++/8/cassert:44,
                 from /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/include/llvm/ProfileData/InstrProf.h:40,
                 from /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/include/llvm/Analysis/IndirectCallPromotionAnalysis.h:16,
                 from /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/include/llvm/Transforms/IPO/MemProfContextDisambiguation.h:18,
                 from /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/lib/LTO/LTO.cpp:56:
/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/include/llvm/ProfileData/InstrProf.h: In member function ‘llvm::ArrayRef<llvm::InstrProfValueSiteRecord> llvm::InstrProfRecord::getValueSitesForKind(uint32_t) const’:
/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/include/llvm/ProfileData/InstrProf.h:1000:23: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
     assert(IPVK_First <= ValueKind && ValueKind <= IPVK_Last &&
Step 7 (build cmake config) failure: build cmake config (failure)
...
[5010/7809] Building R600GenMCCodeEmitter.inc...
[5011/7809] Building R600GenSubtargetInfo.inc...
[5012/7809] Building SPIRVGenAsmWriter.inc...
[5013/7809] Building SPIRVGenGlobalISel.inc...
[5014/7809] Building SPIRVGenInstrInfo.inc...
[5015/7809] Building SPIRVGenRegisterInfo.inc...
[5016/7809] Building SPIRVGenSubtargetInfo.inc...
[5017/7809] Building SPIRVGenRegisterBank.inc...
[5018/7809] Building SPIRVGenMCCodeEmitter.inc...
[5019/7809] Building SPIRVGenPreLegalizeGICombiner.inc...
FAILED: lib/Target/SPIRV/SPIRVGenPreLegalizeGICombiner.inc /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/lib/Target/SPIRV/SPIRVGenPreLegalizeGICombiner.inc 
cd /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/lib/Target/SPIRV && /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/bin/llvm-tblgen -gen-global-isel-combiner -combiners="SPIRVPreLegalizerCombiner" -I /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/lib/Target/SPIRV -I/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/include -I/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/include -I /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/lib/Target /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/lib/Target/SPIRV/SPIRV.td --write-if-changed -o SPIRVGenPreLegalizeGICombiner.inc -d SPIRVGenPreLegalizeGICombiner.inc.d && /usr/bin/cmake -E cmake_transform_depfile Ninja gccdepfile /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/lib/Target/SPIRV /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/lib/Target/SPIRV /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/lib/Target/SPIRV/SPIRVGenPreLegalizeGICombiner.inc.d /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/CMakeFiles/d/7cd2fd85e424a7f3874819f478986a2e4f343a9e41f30908c1f456e5e69bde96.d
llvm-tblgen: /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/utils/TableGen/GlobalISelCombinerEmitter.cpp:2615: virtual void {anonymous}::GICombinerEmitter::emitTestSimplePredicate(llvm::raw_ostream&): Assertion `ExpectedID == ID && "combine rules are not ordered!"' failed.
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace.
Stack dump:
0.	Program arguments: /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/bin/llvm-tblgen -gen-global-isel-combiner -combiners=SPIRVPreLegalizerCombiner -I /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/lib/Target/SPIRV -I/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/include -I/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/include -I /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/lib/Target /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/lib/Target/SPIRV/SPIRV.td --write-if-changed -o SPIRVGenPreLegalizeGICombiner.inc -d SPIRVGenPreLegalizeGICombiner.inc.d
 #0 0x00007a9191be5318 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/bin/../lib/libLLVMSupport.so.21.0git+0x1e5318)
 #1 0x00007a9191be29ec SignalHandler(int, siginfo_t*, void*) Signals.cpp:0:0
 #2 0x00007a9191ff2990 __restore_rt (/lib64/libpthread.so.0+0x12990)
 #3 0x00007a9190d4952f raise (/lib64/libc.so.6+0x4e52f)
 #4 0x00007a9190d1ce65 abort (/lib64/libc.so.6+0x21e65)
 #5 0x00007a9190d1cd39 _nl_load_domain.cold.0 (/lib64/libc.so.6+0x21d39)
 #6 0x00007a9190d41e86 (/lib64/libc.so.6+0x46e86)
 #7 0x00000000005e82b8 (/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/bin/llvm-tblgen+0x5e82b8)
 #8 0x000000000046f732 llvm::GlobalISelMatchTableExecutorEmitter::emitExecutorImpl(llvm::raw_ostream&, llvm::gi::MatchTable const&, llvm::ArrayRef<llvm::gi::LLTCodeGen>, llvm::ArrayRef<llvm::gi::RuleMatcher>, llvm::ArrayRef<llvm::Record const*>, llvm::ArrayRef<llvm::StringRef>, llvm::StringRef) (/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/bin/llvm-tblgen+0x46f732)
 #9 0x00000000005fe1af EmitGICombiner(llvm::RecordKeeper const&, llvm::raw_ostream&) GlobalISelCombinerEmitter.cpp:0:0
#10 0x00007a919225126a llvm::TableGen::Emitter::ApplyCallback(llvm::RecordKeeper const&, llvm::raw_ostream&) (/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/bin/../lib/libLLVMTableGen.so.21.0git+0x5126a)
#11 0x00007a9192222690 llvm::TableGenMain(char const*, std::function<bool (llvm::raw_ostream&, llvm::RecordKeeper const&)>) (/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/bin/../lib/libLLVMTableGen.so.21.0git+0x22690)
#12 0x000000000043fd1e tblgen_main(int, char**) (/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/bin/llvm-tblgen+0x43fd1e)
#13 0x00007a9190d357e5 __libc_start_main (/lib64/libc.so.6+0x3a7e5)
#14 0x000000000040e77e _start (/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/bin/llvm-tblgen+0x40e77e)
/bin/sh: line 1: 3680553 Aborted                 (core dumped) /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/bin/llvm-tblgen -gen-global-isel-combiner -combiners="SPIRVPreLegalizerCombiner" -I /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/lib/Target/SPIRV -I/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/include -I/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/include -I /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/lib/Target /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/lib/Target/SPIRV/SPIRV.td --write-if-changed -o SPIRVGenPreLegalizeGICombiner.inc -d SPIRVGenPreLegalizeGICombiner.inc.d
[5020/7809] Building SPIRVGenTables.inc...
[5021/7809] Building X86GenCallingConv.inc...
[5022/7809] Building X86GenAsmWriter1.inc...
[5023/7809] Building X86GenAsmWriter.inc...
[5024/7809] Building X86GenAsmMatcher.inc...
[5025/7809] Building X86GenDisassemblerTables.inc...
[5026/7809] Building CXX object tools/flang/lib/Support/CMakeFiles/FortranSupport.dir/OpenMP-utils.cpp.o
[5027/7809] Building CXX object lib/CodeGen/AsmPrinter/CMakeFiles/LLVMAsmPrinter.dir/AsmPrinter.cpp.o
[5028/7809] Building CXX object lib/LTO/CMakeFiles/LLVMLTO.dir/LTO.cpp.o
In file included from /usr/include/c++/8/cassert:44,
                 from /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/include/llvm/ProfileData/InstrProf.h:40,
                 from /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/include/llvm/Analysis/IndirectCallPromotionAnalysis.h:16,
                 from /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/include/llvm/Transforms/IPO/MemProfContextDisambiguation.h:18,
                 from /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/lib/LTO/LTO.cpp:56:
/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/include/llvm/ProfileData/InstrProf.h: In member function ‘llvm::ArrayRef<llvm::InstrProfValueSiteRecord> llvm::InstrProfRecord::getValueSitesForKind(uint32_t) const’:
/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/include/llvm/ProfileData/InstrProf.h:1000:23: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
     assert(IPVK_First <= ValueKind && ValueKind <= IPVK_Last &&

```

</details>

https://github.com/llvm/llvm-project/pull/139715