[compiler-rt] [compiler-rt] Replace deprecated os_trace calls on mac (PR #138908)

[Julian Lettner via llvm-commits]

================
@@ -844,30 +844,26 @@ void LogMessageOnPrintf(const char *str) {
 
 void LogFullErrorReport(const char *buffer) {
 #if !SANITIZER_GO
-  // Log with os_trace. This will make it into the crash log.
-#if SANITIZER_OS_TRACE
-#pragma clang diagnostic push
-// os_trace is deprecated.
-#pragma clang diagnostic ignored "-Wdeprecated-declarations"
-  if (GetMacosAlignedVersion() >= MacosVersion(10, 10)) {
-    // os_trace requires the message (format parameter) to be a string literal.
+#    if SANITIZER_OS_TRACE
+  // Log with os_log_error. This will make it into the crash log.
+  if (GetMacosAlignedVersion() >= MacosVersion(10, 12)) {
----------------
yln wrote:

>  it seems that these new os_log_error calls are available in all supported macOS above the minimum version required for sanitizer support: ma

Could we completely omit the check then?  No point in trying to preserve runtime compatibility with < macOS 10.13.

https://github.com/llvm/llvm-project/pull/138908