[llvm] [RISCV] Remove`riscv.segN.load/store` in favor of their mask variants (PR #137045)
Luke Lau via llvm-commits
llvm-commits at lists.llvm.org
Mon May 12 07:07:08 PDT 2025
lukel97 wrote:
> Back when I had submitted #91573 for a similar issue elsewhere, it had been said that we should update the intrinsics to take pointer type. Should we include a similar check here to skip non-default address spaces so that we don't crash, or should we take this as a good opportunity to add proper support for non-default address spaces?
Argh thanks for the reminder, sorry that this ended up being broken again.
But yes, I think we should do both. We should move the address space check in `RISCVTargetLowering::isLegalInterleavedAccessType` to bail for fixed-length vectors to stop the crashing for now.
What do we need to do to support non-default address spaces? If we're just "expecting the backend to ignore them", then is it just a matter of adding pointer type overloads to the memory intrinsics?
https://github.com/llvm/llvm-project/pull/137045
More information about the llvm-commits
mailing list