[llvm] [AMDGPU] si-peephole-sdwa: Fix cndmask vcc use for wave32 (PR #139541)
Frederik Harwath via llvm-commits
llvm-commits at lists.llvm.org
Mon May 12 05:46:43 PDT 2025
================
@@ -1105,6 +1105,7 @@ void SIPeepholeSDWA::convertVcndmaskToVOP2(MachineInstr &MI,
.add(*TII->getNamedOperand(MI, AMDGPU::OpName::src0))
.add(*TII->getNamedOperand(MI, AMDGPU::OpName::src1))
.setMIFlags(MI.getFlags());
+ TII->fixImplicitOperands(*Converted);
----------------
frederik-h wrote:
Right, but I think the same problem exists for the other instructions that are handled in a similar way, i.e. `V_SUB_CO_U32_e64` and `V_ADD_CO_U32_e64`. It's not necessarily wrong, but sub-optimal. I can try to get rid of this, but I suggest to bring in this bug fix first.
https://github.com/llvm/llvm-project/pull/139541
More information about the llvm-commits
mailing list